| Message ID | 1458557331-59540-1-git-send-email-nora.bjorklund@enea.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Scott Wood |
| Headers | show |
On Mon, 2016-03-21 at 11:48 +0100, Nora Björklund wrote: > Enable the gpio-expander pca9672 on p2041rdb. The expander > has been present on the p2041rdb all along, however not in > the device tree. > > Signed-off-by: Nora Björklund <nora.bjorklund@enea.com> > --- > arch/powerpc/boot/dts/fsl/p2041rdb.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/powerpc/boot/dts/fsl/p2041rdb.dts > b/arch/powerpc/boot/dts/fsl/p2041rdb.dts > index e9bd894..b1ee561 100644 > --- a/arch/powerpc/boot/dts/fsl/p2041rdb.dts > +++ b/arch/powerpc/boot/dts/fsl/p2041rdb.dts > @@ -134,6 +134,13 @@ > }; > }; > > + i2c@119100 { > + gpio@22 { > + compatible = "pcf8575"; > + reg = <0x22>; > + }; > + }; The compatible should be "nxp,pcf8575" and it needs the gpio-controller and #gpio-cells properties. Is there an interrupt line connected to it? See Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt -Scott
On Mon, 2016-03-21 at 12:58 -0500, Scott Wood wrote: > On Mon, 2016-03-21 at 11:48 +0100, Nora Björklund wrote: > > > > Enable the gpio-expander pca9672 on p2041rdb. The expander > > has been present on the p2041rdb all along, however not in > > the device tree. > > > > Signed-off-by: Nora Björklund <nora.bjorklund@enea.com> > > --- > > arch/powerpc/boot/dts/fsl/p2041rdb.dts | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/powerpc/boot/dts/fsl/p2041rdb.dts > > b/arch/powerpc/boot/dts/fsl/p2041rdb.dts > > index e9bd894..b1ee561 100644 > > --- a/arch/powerpc/boot/dts/fsl/p2041rdb.dts > > +++ b/arch/powerpc/boot/dts/fsl/p2041rdb.dts > > @@ -134,6 +134,13 @@ > > }; > > }; > > > > + i2c@119100 { > > + gpio@22 { > > + compatible = "pcf8575"; > > + reg = <0x22>; > > + }; > > + }; > The compatible should be "nxp,pcf8575" and it needs the gpio- > controller and > #gpio-cells properties. Sorry, the compatible should actually be "nxp,pca9672".. > > Is there an interrupt line connected to it? PCA9672 has an interrupt line, and it should be connected to irqpin0 if the namegiving in the p2041rdb UG is following the same pattern as the kernel. Will try to test and update during the week. /Nora > :q > See Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt > > -Scott > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev
diff --git a/arch/powerpc/boot/dts/fsl/p2041rdb.dts b/arch/powerpc/boot/dts/fsl/p2041rdb.dts index e9bd894..b1ee561 100644 --- a/arch/powerpc/boot/dts/fsl/p2041rdb.dts +++ b/arch/powerpc/boot/dts/fsl/p2041rdb.dts @@ -134,6 +134,13 @@ }; }; + i2c@119100 { + gpio@22 { + compatible = "pcf8575"; + reg = <0x22>; + }; + }; + usb1: usb@211000 { dr_mode = "host"; };
Enable the gpio-expander pca9672 on p2041rdb. The expander has been present on the p2041rdb all along, however not in the device tree. Signed-off-by: Nora Björklund <nora.bjorklund@enea.com> --- arch/powerpc/boot/dts/fsl/p2041rdb.dts | 7 +++++++ 1 file changed, 7 insertions(+)