| Message ID | 1458545743-3938-2-git-send-email-purna.mandal@microchip.com |
|---|---|
| State | Accepted |
| Delegated to: | Marek Vasut |
| Headers | show |
On 03/21/2016 08:35 AM, Purna Chandra Mandal wrote: > ARM defines __raw_writes[bwql], __raw_reads[bwql] in arch io.h > but not the writes[bwql], reads[bwql] needed by some drivers. > > Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> Applied all four to u-boot-usb/master, thanks!
On 03/21/2016 04:49 PM, Marek Vasut wrote: > On 03/21/2016 08:35 AM, Purna Chandra Mandal wrote: >> ARM defines __raw_writes[bwql], __raw_reads[bwql] in arch io.h >> but not the writes[bwql], reads[bwql] needed by some drivers. >> >> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> > Applied all four to u-boot-usb/master, thanks! > Thanks. :)
On 03/21/2016 12:19 PM, Purna Chandra Mandal wrote: > On 03/21/2016 04:49 PM, Marek Vasut wrote: > >> On 03/21/2016 08:35 AM, Purna Chandra Mandal wrote: >>> ARM defines __raw_writes[bwql], __raw_reads[bwql] in arch io.h >>> but not the writes[bwql], reads[bwql] needed by some drivers. >>> >>> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> >> Applied all four to u-boot-usb/master, thanks! >> > Thanks. :) > Thank you for persevering ;-) btw. have you worked with Olimex PIC32-EMZ64 (PIC32MZ2048EFH064) ? Can it be used for testing U-Boot on PIC32 and this musb stuff ?
On 03/21/2016 05:09 PM, Marek Vasut wrote: > On 03/21/2016 12:19 PM, Purna Chandra Mandal wrote: >> On 03/21/2016 04:49 PM, Marek Vasut wrote: >> >>> On 03/21/2016 08:35 AM, Purna Chandra Mandal wrote: >>>> ARM defines __raw_writes[bwql], __raw_reads[bwql] in arch io.h >>>> but not the writes[bwql], reads[bwql] needed by some drivers. >>>> >>>> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> >>> Applied all four to u-boot-usb/master, thanks! >>> >> Thanks. :) >> > Thank you for persevering ;-) > > btw. have you worked with Olimex PIC32-EMZ64 (PIC32MZ2048EFH064) ? > Can it be used for testing U-Boot on PIC32 and this musb stuff ? Not exactly 'PIC32MZ2048EFH064' but on some other board having PIC32MZ2048EFM144 (with additional SRAM connected on EBI). Anyway MUSB stuff is same. And pin-mapping will be different so need to update pinctrl. Otherwise it should be fine for U-Boot testing.
On 03/21/2016 12:44 PM, Purna Chandra Mandal wrote: > On 03/21/2016 05:09 PM, Marek Vasut wrote: >> On 03/21/2016 12:19 PM, Purna Chandra Mandal wrote: >>> On 03/21/2016 04:49 PM, Marek Vasut wrote: >>> >>>> On 03/21/2016 08:35 AM, Purna Chandra Mandal wrote: >>>>> ARM defines __raw_writes[bwql], __raw_reads[bwql] in arch io.h >>>>> but not the writes[bwql], reads[bwql] needed by some drivers. >>>>> >>>>> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> >>>> Applied all four to u-boot-usb/master, thanks! >>>> >>> Thanks. :) >>> >> Thank you for persevering ;-) >> >> btw. have you worked with Olimex PIC32-EMZ64 (PIC32MZ2048EFH064) ? >> Can it be used for testing U-Boot on PIC32 and this musb stuff ? > > Not exactly 'PIC32MZ2048EFH064' but on some other board having > PIC32MZ2048EFM144 (with additional SRAM connected on EBI). > Anyway MUSB stuff is same. And pin-mapping will be different > so need to update pinctrl. Otherwise it should be fine for U-Boot > testing. I see, thanks!
Hi, Am 21.03.2016 um 08:35 schrieb Purna Chandra Mandal: > ARM defines __raw_writes[bwql], __raw_reads[bwql] in arch io.h > but not the writes[bwql], reads[bwql] needed by some drivers. > > Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> > --- sorry for noticing this so late, but this patch is assigned to me in patchwork. I think this patch [1] as well as [2] should be merged via Albert's u-boot-arm tree, shouldn't it? [1] http://patchwork.ozlabs.org/patch/599979/ [2] http://patchwork.ozlabs.org/patch/599980/ > > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > arch/arm/include/asm/io.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h > index 75773bd..9d185a6 100644 > --- a/arch/arm/include/asm/io.h > +++ b/arch/arm/include/asm/io.h > @@ -284,6 +284,13 @@ static inline void __raw_readsl(unsigned long addr, void *data, int longlen) > #define insw_p(port,to,len) insw(port,to,len) > #define insl_p(port,to,len) insl(port,to,len) > > +#define writesl(a, d, s) __raw_writesl((unsigned long)a, d, s) > +#define readsl(a, d, s) __raw_readsl((unsigned long)a, d, s) > +#define writesw(a, d, s) __raw_writesw((unsigned long)a, d, s) > +#define readsw(a, d, s) __raw_readsw((unsigned long)a, d, s) > +#define writesb(a, d, s) __raw_writesb((unsigned long)a, d, s) > +#define readsb(a, d, s) __raw_readsb((unsigned long)a, d, s) > + > /* > * ioremap and friends. > * >
On 04/10/2016 07:03 PM, Daniel Schwierzeck wrote: > Hi, > > Am 21.03.2016 um 08:35 schrieb Purna Chandra Mandal: >> ARM defines __raw_writes[bwql], __raw_reads[bwql] in arch io.h >> but not the writes[bwql], reads[bwql] needed by some drivers. >> >> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> >> --- > > sorry for noticing this so late, but this patch is assigned to me in > patchwork. I think this patch [1] as well as [2] should be merged via > Albert's u-boot-arm tree, shouldn't it? > > [1] http://patchwork.ozlabs.org/patch/599979/ > [2] http://patchwork.ozlabs.org/patch/599980/ Since this is part of usb series, I will pick it via u-boot-usb and send PR shortly. Best regards, Marek Vasut
Am 10.04.2016 um 19:18 schrieb Marek Vasut: > On 04/10/2016 07:03 PM, Daniel Schwierzeck wrote: >> Hi, >> >> Am 21.03.2016 um 08:35 schrieb Purna Chandra Mandal: >>> ARM defines __raw_writes[bwql], __raw_reads[bwql] in arch io.h >>> but not the writes[bwql], reads[bwql] needed by some drivers. >>> >>> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> >>> --- >> >> sorry for noticing this so late, but this patch is assigned to me in >> patchwork. I think this patch [1] as well as [2] should be merged via >> Albert's u-boot-arm tree, shouldn't it? >> >> [1] http://patchwork.ozlabs.org/patch/599979/ >> [2] http://patchwork.ozlabs.org/patch/599980/ > > Since this is part of usb series, I will pick it via u-boot-usb and send > PR shortly. > ok, can I reassign all four patches to you?
On 04/10/2016 07:26 PM, Daniel Schwierzeck wrote: > > > Am 10.04.2016 um 19:18 schrieb Marek Vasut: >> On 04/10/2016 07:03 PM, Daniel Schwierzeck wrote: >>> Hi, >>> >>> Am 21.03.2016 um 08:35 schrieb Purna Chandra Mandal: >>>> ARM defines __raw_writes[bwql], __raw_reads[bwql] in arch io.h >>>> but not the writes[bwql], reads[bwql] needed by some drivers. >>>> >>>> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> >>>> --- >>> >>> sorry for noticing this so late, but this patch is assigned to me in >>> patchwork. I think this patch [1] as well as [2] should be merged via >>> Albert's u-boot-arm tree, shouldn't it? >>> >>> [1] http://patchwork.ozlabs.org/patch/599979/ >>> [2] http://patchwork.ozlabs.org/patch/599980/ >> >> Since this is part of usb series, I will pick it via u-boot-usb and send >> PR shortly. >> > > ok, can I reassign all four patches to you? > Sure, and mark them as applied while at it ;-)
diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h index 75773bd..9d185a6 100644 --- a/arch/arm/include/asm/io.h +++ b/arch/arm/include/asm/io.h @@ -284,6 +284,13 @@ static inline void __raw_readsl(unsigned long addr, void *data, int longlen) #define insw_p(port,to,len) insw(port,to,len) #define insl_p(port,to,len) insl(port,to,len) +#define writesl(a, d, s) __raw_writesl((unsigned long)a, d, s) +#define readsl(a, d, s) __raw_readsl((unsigned long)a, d, s) +#define writesw(a, d, s) __raw_writesw((unsigned long)a, d, s) +#define readsw(a, d, s) __raw_readsw((unsigned long)a, d, s) +#define writesb(a, d, s) __raw_writesb((unsigned long)a, d, s) +#define readsb(a, d, s) __raw_readsb((unsigned long)a, d, s) + /* * ioremap and friends. *
ARM defines __raw_writes[bwql], __raw_reads[bwql] in arch io.h but not the writes[bwql], reads[bwql] needed by some drivers. Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None arch/arm/include/asm/io.h | 7 +++++++ 1 file changed, 7 insertions(+)