S5PC110: Add OneNAND interrupt number

Submitted by Kyungmin Park on July 27, 2010, 10:39 a.m.

Details

Message ID 20100727103937.GA1247@july
State New, archived
Headers show

Commit Message

Kyungmin Park July 27, 2010, 10:39 a.m.
To use OneNAND interrupt at drivers, also extend DMA address to cover fully.

Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---

Comments

Artem Bityutskiy Aug. 5, 2010, 4:32 a.m.
On Tue, 2010-07-27 at 19:39 +0900, Kyungmin Park wrote:
> To use OneNAND interrupt at drivers, also extend DMA address to cover fully.
> 
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> diff --git a/arch/arm/mach-s5pv210/dev-onenand.c b/arch/arm/mach-s5pv210/dev-onenand.c
> index 34997b7..f8ede33 100644
> --- a/arch/arm/mach-s5pv210/dev-onenand.c
> +++ b/arch/arm/mach-s5pv210/dev-onenand.c
> @@ -27,9 +27,14 @@ static struct resource s5pc110_onenand_resources[] = {
>  	},
>  	[1] = {
>  		.start	= S5PC110_PA_ONENAND_DMA,
> -		.end	= S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
> +		.end	= S5PC110_PA_ONENAND_DMA + SZ_8K - 1,
>  		.flags	= IORESOURCE_MEM,
>  	},
> +	[2] = {
> +		.start	= IRQ_ONENAND_AUDI,
> +		.end	= IRQ_ONENAND_AUDI,
> +		.flags	= IORESOURCE_IRQ,
> +	},
>  };

You do not expect this to go through the MTD tree, right?
Kyungmin Park Aug. 5, 2010, 5:51 a.m.
On Thu, Aug 5, 2010 at 1:32 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Tue, 2010-07-27 at 19:39 +0900, Kyungmin Park wrote:
>> To use OneNAND interrupt at drivers, also extend DMA address to cover fully.
>>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> diff --git a/arch/arm/mach-s5pv210/dev-onenand.c b/arch/arm/mach-s5pv210/dev-onenand.c
>> index 34997b7..f8ede33 100644
>> --- a/arch/arm/mach-s5pv210/dev-onenand.c
>> +++ b/arch/arm/mach-s5pv210/dev-onenand.c
>> @@ -27,9 +27,14 @@ static struct resource s5pc110_onenand_resources[] = {
>>       },
>>       [1] = {
>>               .start  = S5PC110_PA_ONENAND_DMA,
>> -             .end    = S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
>> +             .end    = S5PC110_PA_ONENAND_DMA + SZ_8K - 1,
>>               .flags  = IORESOURCE_MEM,
>>       },
>> +     [2] = {
>> +             .start  = IRQ_ONENAND_AUDI,
>> +             .end    = IRQ_ONENAND_AUDI,
>> +             .flags  = IORESOURCE_IRQ,
>> +     },
>>  };
>
> You do not expect this to go through the MTD tree, right?

After this patch, I did a lot of works but failed to persuade the Kukjin.
At this time. it's okay only this patch to mtd tree.

Kukjin, are you okay?
Since It's only affect the c110.

Thank you,
Kyungmin Park
Kukjin Kim Aug. 5, 2010, 6:15 a.m.
Kyungmin Park wrote:
> 
> On Thu, Aug 5, 2010 at 1:32 PM, Artem Bityutskiy <dedekind1@gmail.com>
wrote:
> > On Tue, 2010-07-27 at 19:39 +0900, Kyungmin Park wrote:
> >> To use OneNAND interrupt at drivers, also extend DMA address to cover
fully.
> >>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >> ---
> >> diff --git a/arch/arm/mach-s5pv210/dev-onenand.c b/arch/arm/mach-
> s5pv210/dev-onenand.c
> >> index 34997b7..f8ede33 100644
> >> --- a/arch/arm/mach-s5pv210/dev-onenand.c
> >> +++ b/arch/arm/mach-s5pv210/dev-onenand.c
> >> @@ -27,9 +27,14 @@ static struct resource s5pc110_onenand_resources[] =
{
> >>       },
> >>       [1] = {
> >>               .start  = S5PC110_PA_ONENAND_DMA,
> >> -             .end    = S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
> >> +             .end    = S5PC110_PA_ONENAND_DMA + SZ_8K - 1,
> >>               .flags  = IORESOURCE_MEM,
> >>       },
> >> +     [2] = {
> >> +             .start  = IRQ_ONENAND_AUDI,
> >> +             .end    = IRQ_ONENAND_AUDI,
> >> +             .flags  = IORESOURCE_IRQ,
> >> +     },
> >>  };
> >
> > You do not expect this to go through the MTD tree, right?
> 
> After this patch, I did a lot of works but failed to persuade the Kukjin.

Maybe I missed this single patch...looks ok itself.

> At this time. it's okay only this patch to mtd tree.
> 
I think, it's better this patch is going to upstream through ARM tree.

Artem, I will apply in my tree. Thanks.

> Kukjin, are you okay?
> Since It's only affect the c110.
> 

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

Patch hide | download patch | download mbox

diff --git a/arch/arm/mach-s5pv210/dev-onenand.c b/arch/arm/mach-s5pv210/dev-onenand.c
index 34997b7..f8ede33 100644
--- a/arch/arm/mach-s5pv210/dev-onenand.c
+++ b/arch/arm/mach-s5pv210/dev-onenand.c
@@ -27,9 +27,14 @@  static struct resource s5pc110_onenand_resources[] = {
 	},
 	[1] = {
 		.start	= S5PC110_PA_ONENAND_DMA,
-		.end	= S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
+		.end	= S5PC110_PA_ONENAND_DMA + SZ_8K - 1,
 		.flags	= IORESOURCE_MEM,
 	},
+	[2] = {
+		.start	= IRQ_ONENAND_AUDI,
+		.end	= IRQ_ONENAND_AUDI,
+		.flags	= IORESOURCE_IRQ,
+	},
 };
 
 struct platform_device s5pc110_device_onenand = {