| Message ID | 1458483028-9370-1-git-send-email-trini@konsulko.com |
|---|---|
| State | Accepted |
| Commit | f09144a220ce71d628830f7ccadeacd0cfdf6d76 |
| Delegated to: | Simon Glass |
| Headers | show |
On 21 March 2016 at 03:10, Tom Rini <trini@konsulko.com> wrote: > > LLVM 3.5 noted: > test/dm/core.c:41:35: warning: unused variable 'test_pdata_pre_reloc' [-Wunused-const-variable] > static const struct dm_test_pdata test_pdata_pre_reloc = { > > And the correct fix here is that the driver_info_pre_reloc test should > use the test_pdata_pre_reloc not test_pdata_manual variable > > Cc: Simon Glass <sjg@chromium.org> > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > test/dm/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> Unfortunately it seems there is no test that actually uses this.
On 29 March 2016 at 03:42, Simon Glass <sjg@chromium.org> wrote: > On 21 March 2016 at 03:10, Tom Rini <trini@konsulko.com> wrote: >> >> LLVM 3.5 noted: >> test/dm/core.c:41:35: warning: unused variable 'test_pdata_pre_reloc' [-Wunused-const-variable] >> static const struct dm_test_pdata test_pdata_pre_reloc = { >> >> And the correct fix here is that the driver_info_pre_reloc test should >> use the test_pdata_pre_reloc not test_pdata_manual variable >> >> Cc: Simon Glass <sjg@chromium.org> >> Signed-off-by: Tom Rini <trini@konsulko.com> >> --- >> test/dm/core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> > > Unfortunately it seems there is no test that actually uses this. Applied to u-boot-dm, thanks!
diff --git a/test/dm/core.c b/test/dm/core.c index 9fbc70d..70bf4d0 100644 --- a/test/dm/core.c +++ b/test/dm/core.c @@ -64,7 +64,7 @@ static struct driver_info driver_info_manual = { static struct driver_info driver_info_pre_reloc = { .name = "test_pre_reloc_drv", - .platdata = &test_pdata_manual, + .platdata = &test_pdata_pre_reloc, }; void dm_leak_check_start(struct unit_test_state *uts)
LLVM 3.5 noted: test/dm/core.c:41:35: warning: unused variable 'test_pdata_pre_reloc' [-Wunused-const-variable] static const struct dm_test_pdata test_pdata_pre_reloc = { And the correct fix here is that the driver_info_pre_reloc test should use the test_pdata_pre_reloc not test_pdata_manual variable Cc: Simon Glass <sjg@chromium.org> Signed-off-by: Tom Rini <trini@konsulko.com> --- test/dm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)