| Message ID | 1458297902-19730-1-git-send-email-prabhakar.kushwaha@nxp.com |
|---|---|
| State | Accepted |
| Commit | b576d325acbcbe05d712e3a995b4ce6689eb96c5 |
| Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3qRMjF6cbLz9sCZ for <incoming@patchwork.ozlabs.org>; Fri, 18 Mar 2016 22:01:21 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 65B87A76CE; Fri, 18 Mar 2016 12:01:17 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 69Oq1cVz0YbM; Fri, 18 Mar 2016 12:01:17 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D818FA76BB; Fri, 18 Mar 2016 12:01:16 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 38A5BA76CB for <u-boot@lists.denx.de>; Fri, 18 Mar 2016 12:01:15 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8-nGersnyrKF for <u-boot@lists.denx.de>; Fri, 18 Mar 2016 12:01:15 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0063.outbound.protection.outlook.com [157.56.111.63]) by theia.denx.de (Postfix) with ESMTPS id 28E2EA76E2 for <u-boot@lists.denx.de>; Fri, 18 Mar 2016 12:01:09 +0100 (CET) Received: from BN3PR0301CA0033.namprd03.prod.outlook.com (10.160.180.171) by BY2PR0301MB1590.namprd03.prod.outlook.com (10.163.28.20) with Microsoft SMTP Server (TLS) id 15.1.443.7; Fri, 18 Mar 2016 10:45:09 +0000 Received: from BL2FFO11OLC003.protection.gbl (2a01:111:f400:7c09::135) by BN3PR0301CA0033.outlook.office365.com (2a01:111:e400:4000::43) with Microsoft SMTP Server (TLS) id 15.1.434.16 via Frontend Transport; Fri, 18 Mar 2016 10:45:09 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11OLC003.mail.protection.outlook.com (10.173.161.187) with Microsoft SMTP Server (TLS) id 15.1.443.6 via Frontend Transport; Fri, 18 Mar 2016 10:45:09 +0000 Received: from b32579-VirtualBox.ap.freescale.net (B32579-02.ap.freescale.net [10.232.40.8]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u2IAj3HI014756; Fri, 18 Mar 2016 03:45:06 -0700 From: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> To: <u-boot@lists.denx.de> Date: Fri, 18 Mar 2016 16:15:02 +0530 Message-ID: <1458297902-19730-1-git-send-email-prabhakar.kushwaha@nxp.com> X-Mailer: git-send-email 1.9.1 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131027715092196007; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(19580405001)(85426001)(19580395003)(48376002)(47776003)(87936001)(50466002)(81166005)(33646002)(189998001)(77096005)(86362001)(2351001)(50226001)(110136002)(92566002)(106466001)(50986999)(105606002)(229853001)(4326007)(2906002)(1220700001)(1096002)(6806005)(104016004)(5008740100001)(586003)(11100500001)(5003940100001)(36756003)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB1590; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC003; 1:CNB64e5vvf7CnFUXMSbljwxRoqlGdJyNyNgxCiPjc8x5UY0mR6vfEkoZ8YdJKYelWbMhN//90y1uBXeIXmcl38YNN5Zabw4TB7/rCTXMpaCj19+rYvrhBoUr9hc7P4VpjthdHFOioOeqMLTMGo5fpUZjQ24Y0SmUk2NMqebiyBAnQAFHumTDEwgM4yiVRfF0VsDZWXMhtqIOZQRZlVm3Etjnzt8DYcXDbgMSgdhfdZqhbb5C+Q3+H/EThxzfw5aNZ52CLnZoqdQWivSkcyArBWVnVcr8nWrDPgPMnggsQyTCTmc1HxBC3zNg7A1O23Z+BvR2wiCwMyfAg+sHdO5B8kh28RSqq6zhzRVTOFnmLmy/YfUIN5IXt+Bk7m3K9ZyQIZlq+85I1P1GIRfsBz9Q4clnM/nDIVQ55VwUANFiOQtjJRIS3bX0VMtKTX4AVsYZ8QHU6vZX1PeoiOHAPjH3XrwQuT/fv/HMCzcjBNwsODc2PYiibDa4EsPpfRZ4DCzQVDJsrmeKtLxCTxojxmzHybggK/1FReeyMKurp8nzJq5lsoD4tKOOX4l08SYbkPdUfksljQSvaUOaBGJJqtNZEM66r5cbD6+1XOzlMr8q8tNb+nMFpQz6VAq+pdqK4t71 MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: da47779d-8d91-491b-2aa7-08d34f1a6044 X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1590; 2:eCZKWKozjfvkGxO87mckb0eVVk9EIeo8v3JDn74vwRxW+bSuTrUuxwaHwGecfmOSet1ovNFXBvkjR3hXqRk6RhDgZchs/UDA1ipAxa68su3c+exLjVEkFBIx7UpnzOTPvR12bD0XBut68DG25G+Zwh/QhHcNX0SJq3IJ3CJvVoQhyk7qwkpejk70Tf5GZpIQ; 3:JCuTnBMh5i8WzEKicHeVncBARspyh8Ib1zONJEIurQl7jtfxtLiXcIMxh9C7Gk+8gJI8LC+apva8yFh0E7dnXEHdBX6TGs/eneYWLkOvWiKKVUQH4w8hUyWl5DNlnKlqobkGy9Kj4ay77omeJHINiZvo7icwYkntKgPjLBPCn9Zsbg9dXbjMegqpiIsoD33BoFOiqrSof/sMtax/FwKLt1G23sqnzFNC61wwULc1ue8= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB1590; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1590; 25:UgXlTx7bAgidIfase5CgAOEQQGnMq1yIeEjHw8oHLjI9JymfRCLVvT6FCasfK7oEQRt+LPr+kzoIuWt9DAZeZPWj4leJ7fYR7BtgyfR91ofshm/tXtb/yocyEIEjoSSVhHAc6dmHkibg9LdilzH+k543pNh36OZ2Aq81qG7shmRkrI7Y/+tgSfRlL3prnA1dx1Rs2MEIaFqZYOq7L8x5SVXgN6usfmFvc3OgyI156KBP/Is+1k3XiJEiukzm8U0ZPXqPStCsnlMMZojfnAv1DgqQrDcXeDWofut1jn0hk39K4xqzSzgQ0+AjLe+pijeSXTN5ATpRGglvRTmZRiiKbroba4FiX6VYFUJ8fwrsSNMDMfNyRfonIXrLFkkWx7hA8JkssMV1nXh2W7PMyDpfXQrNGvWPAahFSzcM1AU2h6EXEWS1lU+/EY8egQRcayPgu2iFZ49TpS8RI44+p0N4V17puklJSNKz/WLaSrTIKEEQNMuoiR5Pc4RaMmjuKPehf/iQvfxxgUFgcx4s73iAg6l3ZDQJq80VwpX3Q/B1hFE= X-Microsoft-Antispam-PRVS: <BY2PR0301MB15908FD3988562D67C7D7FF0978C0@BY2PR0301MB1590.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(13018025)(13023025)(13024025)(13017025)(5005006)(13015025)(10201501046)(3002001); SRVR:BY2PR0301MB1590; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB1590; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1590; 4:c6wjQROU8v7FsdvWPBkmLhKqL3QxLsN074i48EQXQTFdY8ZsHdmsl191Iwa0DNY4N0kq2nm9RmBz6txgs9QrIMV3VMndL9cjjq7Oja6aomNiLPeV7I+/QRCXUAZWN8PvzOD7A4tgBo555wmwPJlk74Tvjieulfic2VNAAcuf74jHPDl2/X9kNODL9/X3EqeiGQh99hiHt5C+xjzat7UC1C95xQLA1zcrUPrB/JieoW7l8FwVHLQB5UR4Tku+lYYOLfuEIaaKNd1F8X1XO6olJcPib9PPydD3d7r+xgmb0MoDEBrkFTW+2YUOX2q4QjKvieH3aeDM3omim6rVdFm0H1y4Mekt3fOqpbiDnPOWEjYI2tws7ys3PuilT3k/qu3rnz3I6P0cTg0AV8d7Z9noNvPbGEwiC8BCagFk1185TqyUw5wAtTyVpUl3OTlPpxZVf0bCKZ9B520JwmIaZBhHHQ== X-Forefront-PRVS: 088552DE73 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0301MB1590; 23:THSA7t4W+wTm2aq2S9xmvTDFt8dtlF537xh9oUK?= =?us-ascii?Q?EuOFHAvT5jkoN11jmWyzs5077pdNiTomln9RB2xUnVZlRuXA72j2Wn71pVyB?= =?us-ascii?Q?fAZWUVuHz8ADdic5QU5UPllw1iLFF7hZjTmcgFX1nlKY3gIhm/m2mWjk5NGQ?= =?us-ascii?Q?D5nx5sVFZF6AfQFyH51TWrPpPDv3cJTeG8yWZ0/qC2IylLk7g+oHHrSNGTfB?= =?us-ascii?Q?OH5tR86X0Bjf7OXfEmB2bkURvG578tCnDpV6ItpVyuJnoCnivxAHdqURpLOi?= =?us-ascii?Q?Sug+hex7o2Tr1W1lD4OCtmEGLu0rqX6E2YZBogF8SeBlhj9cBVS0kXEETYqm?= =?us-ascii?Q?o9zyNI/KGtbzda5UKANfBISAWBtpV10DQ76iDm8h9OKW9e7cdJOd5MOHzQEs?= =?us-ascii?Q?EjUk2cZKh7H1gnjh7wMZ6H8WQXHrSt7EroCUft5NSs4PtSZc46/RqcBqRHY8?= =?us-ascii?Q?w6INtL4+i+/bXGOYMIUGpvuLGHZl2eBWJLHiHNgiHWUD56drerwF2zUN7hTT?= =?us-ascii?Q?FtrPK/2mjmXa5QMFCxC703MJ6f4BR9HaIsRM/Hd2XCBPhU901J5YGp6IaCGD?= =?us-ascii?Q?6h0fFev2dSObVhKnnLJB2NbYA14YRuY8Bk4ouTqPT/xot0BHgaqNiwOZECi6?= =?us-ascii?Q?w8erObAXSxhoqh3NKVIN0G/7ZmR8O2O3nd4TyL6JXegmqalnzR5fnahfMu1Q?= =?us-ascii?Q?XL58im0h7r2M3glCbtR9E/x9ClxeRQ0agcc/nza0fSWjjZgfu0F5zbZs/+3i?= =?us-ascii?Q?3STolV28O8btEJgwVPAfuOfIClRvWDG4iBx5l/ZRErM38LoYX5XbWzpVx1It?= =?us-ascii?Q?T/KBrpcrQuYECrXzf9WQ+cITtSrLsMZ5aysxjKjdNgDUJHknsm5QlVCYBSG0?= =?us-ascii?Q?8Ae71NZLYedb+PVqTgLaYS06UnOsAjEEwXjN7Y6fQT7ksDaV9JSRc0hMRZDk?= =?us-ascii?Q?KeLP0X+INnckzTZ+PHYek0hoE+RMLbPCsBk6Rfk137XdDYn6Sub/+4uJwxry?= =?us-ascii?Q?v2/frADtXWRAyTnTmRU4R8O8A?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1590; 5:60mPPmaxI5Y9Ta2CF43K9DYQ4/+THLzAeWyX+4nw8M0BMROQ9zZblpPxKeBNGCwIjCXhsHorpyKQhWYMOCobWTpG/fisXY7wES8R3gA4eFyXkxI8sM+cbGhOMXR1HDNGuR6sbpxT2SAIa0czg+2XNk/pAPZkZSaEcMfI6AJnFdo=; 24:m82wVqSso7fEnToFf7d3OMaJ4VOizNGsLgjuxC+rvho3i7TP8rA1tYeio5gD2Xx/KZtpxTQh5K59QCdLcmcvqxhPFGOGsLCVRamUq8Xf5HE= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2016 10:45:09.0324 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB1590 Subject: [U-Boot] [PATCH 2/4] driver: net: fsl-mc: Check NULL before pointer dereference X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <http://lists.denx.de/mailman/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <http://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <http://lists.denx.de/mailman/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> |
On Fri, Mar 18, 2016 at 5:45 AM, Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> wrote: > NULL pointer should be checked before any dereference. This patch > move memest after the NULL pointer check. > > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> > Reported-by: Jose Rivera <german.rivera@nxp.com> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
diff --git a/drivers/net/fsl-mc/dpio/qbman_sys.h b/drivers/net/fsl-mc/dpio/qbman_sys.h index 235d641..7a537fb 100644 --- a/drivers/net/fsl-mc/dpio/qbman_sys.h +++ b/drivers/net/fsl-mc/dpio/qbman_sys.h @@ -255,11 +255,11 @@ static inline int qbman_swp_sys_init(struct qbman_swp_sys *s, s->addr_cena = d->cena_bar; s->addr_cinh = d->cinh_bar; s->cena = (void *)valloc(CONFIG_SYS_PAGE_SIZE); - memset((void *)s->cena, 0x00, CONFIG_SYS_PAGE_SIZE); if (!s->cena) { printf("Could not allocate page for cena shadow\n"); return -1; } + memset((void *)s->cena, 0x00, CONFIG_SYS_PAGE_SIZE); #ifdef QBMAN_CHECKING /* We should never be asked to initialise for a portal that isn't in
NULL pointer should be checked before any dereference. This patch move memest after the NULL pointer check. Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> Reported-by: Jose Rivera <german.rivera@nxp.com> --- drivers/net/fsl-mc/dpio/qbman_sys.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)