diff mbox

[U-Boot,1/2] efi_stub: Move carriage return before line feed in putc()

Message ID 1458284344-32149-1-git-send-email-bmeng.cn@gmail.com
State Accepted
Commit 075bb5c6ea7bef0a442d5155b25b273167e67b4a
Delegated to: Tom Rini
Headers show

Commit Message

Bin Meng March 18, 2016, 6:59 a.m. UTC 
A carriage return needs to execute before a line feed.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 lib/efi/efi_stub.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Tom Rini March 18, 2016, 1:26 p.m. UTC | #1 
On Thu, Mar 17, 2016 at 11:59:03PM -0700, Bin Meng wrote:

> A carriage return needs to execute before a line feed.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
Tom Rini March 27, 2016, 10:27 p.m. UTC | #2 
On Thu, Mar 17, 2016 at 11:59:03PM -0700, Bin Meng wrote:

> A carriage return needs to execute before a line feed.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/lib/efi/efi_stub.c b/lib/efi/efi_stub.c
index e138709..8b4bb4e 100644
--- a/lib/efi/efi_stub.c
+++ b/lib/efi/efi_stub.c
@@ -65,6 +65,9 @@  void _debug_uart_init(void)
 
 void putc(const char ch)
 {
+	if (ch == '\n')
+		putc('\r');
+
 	if (use_uart) {
 		NS16550_t com_port = (NS16550_t)0x3f8;
 
@@ -74,8 +77,6 @@  void putc(const char ch)
 	} else {
 		efi_putc(global_priv, ch);
 	}
-	if (ch == '\n')
-		putc('\r');
 }
 
 void puts(const char *str)