Patchwork [testsuite] Correctly declare testcase requirements: pr44900.C, attr-weak-hidden-1a.c

login
register
mail settings
Submitter Rainer Orth
Date July 26, 2010, 4:21 p.m.
Message ID <ydd7hki43kd.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Download mbox | patch
Permalink /patch/59926/
State New
Headers show

Comments

Rainer Orth - July 26, 2010, 4:21 p.m.
Two recent testcases fail on Solaris 8/x86:

FAIL: g++.dg/torture/pr44900.C  -O0  execution test
FAIL: g++.dg/torture/pr44900.C  -O1  execution test
FAIL: g++.dg/torture/pr44900.C  -O2  execution test
FAIL: g++.dg/torture/pr44900.C  -O3 -fomit-frame-pointer  execution test
FAIL: g++.dg/torture/pr44900.C  -O3 -g  execution test
FAIL: g++.dg/torture/pr44900.C  -Os  execution test
FAIL: g++.dg/torture/pr44900.C  -O2 -flto  execution test
FAIL: g++.dg/torture/pr44900.C  -O2 -fwhopr  execution test

This SSE execution test needs sse_runtime, not only sse, to take care of
platforms that cannot execute SSE code for some reason.

FAIL: gcc.dg/attr-weak-hidden-1a.c (test for excess errors)

Excess errors:
/vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.dg/attr-weak-hidden-1a.c:2:1: warning: visibility attribute not supported in this configuration; ignored [-Wattributes]

Needs to declare the visiblity requirement, just as the main test file.

The following patch fixes both issues, tested with the appropriate
runtest invocation, installed as obvious.

	Rainer


2010-07-26  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* g++.dg/torture/pr44900.C: Use dg-require-effective-target
	sse_runtime.
	* gcc.dg/attr-weak-hidden-1a.c: Use dg-require-weak,
	dg-require-visibility.

Patch

diff -r 2b50376e6a9d gcc/testsuite/g++.dg/torture/pr44900.C
--- a/gcc/testsuite/g++.dg/torture/pr44900.C	Wed Jul 21 17:11:44 2010 +0200
+++ b/gcc/testsuite/g++.dg/torture/pr44900.C	Mon Jul 26 18:15:49 2010 +0200
@@ -1,6 +1,6 @@ 
 /* { dg-do run { target i?86-*-* x86_64-*-* } } */
 /* { dg-options "-msse" } */
-/* { dg-require-effective-target sse } */
+/* { dg-require-effective-target sse_runtime } */
 
 typedef float __m128 __attribute__ ((__vector_size__ (16), __may_alias__));
 typedef float __v4sf __attribute__ ((__vector_size__ (16)));
diff -r 2b50376e6a9d gcc/testsuite/gcc.dg/attr-weak-hidden-1a.c
--- a/gcc/testsuite/gcc.dg/attr-weak-hidden-1a.c	Wed Jul 21 17:11:44 2010 +0200
+++ b/gcc/testsuite/gcc.dg/attr-weak-hidden-1a.c	Mon Jul 26 18:15:49 2010 +0200
@@ -1,3 +1,5 @@ 
+/* { dg-require-weak "" } */
+/* { dg-require-visibility "" } */
 void abort (void);
 int __attribute__((weak, visibility("hidden"))) foo (void) { return 1; }
 int