| Message ID | 1458239136-37814-1-git-send-email-jesse@kernel.org |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 2016-03-17 at 11:25 -0700, Jesse Gross wrote: > ipip encapsulated packets can be merged together by GRO but the result > does not have the proper GSO type set or even marked as being > encapsulated at all. Later retransmission of these packets will likely > fail if the device does not support ipip offloads. This is similar to > the issue resolved in IPv6 sit in feec0cb3 > ("ipv6: gro: support sit protocol"). > > Reported-by: Patrick Boutilier <boutilpj@ednet.ns.ca> > Fixes: 9667e9bb ("ipip: Add gro callbacks to ipip offload") > Signed-off-by: Jesse Gross <jesse@kernel.org> > --- Acked-by: Eric Dumazet <edumazet@google.com>
Jesse, can you repost this series with a patch introductory "PATCH 0/3" email explaining things at a high level about what this series is doing? Thanks.
On Fri, Mar 18, 2016 at 8:12 PM, David Miller <davem@davemloft.net> wrote: > > Jesse, can you repost this series with a patch introductory "PATCH > 0/3" email explaining things at a high level about what this series is > doing? > > Thanks. Sure, I just sent a v2 with a cover letter.
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index 0cc923f..9659233 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -1448,6 +1448,13 @@ out_unlock: return err; } +static int ipip_gro_complete(struct sk_buff *skb, int nhoff) +{ + skb->encapsulation = 1; + skb_shinfo(skb)->gso_type |= SKB_GSO_IPIP; + return inet_gro_complete(skb, nhoff); +} + int inet_ctl_sock_create(struct sock **sk, unsigned short family, unsigned short type, unsigned char protocol, struct net *net) @@ -1676,7 +1683,7 @@ static const struct net_offload ipip_offload = { .callbacks = { .gso_segment = inet_gso_segment, .gro_receive = inet_gro_receive, - .gro_complete = inet_gro_complete, + .gro_complete = ipip_gro_complete, }, };
ipip encapsulated packets can be merged together by GRO but the result does not have the proper GSO type set or even marked as being encapsulated at all. Later retransmission of these packets will likely fail if the device does not support ipip offloads. This is similar to the issue resolved in IPv6 sit in feec0cb3 ("ipv6: gro: support sit protocol"). Reported-by: Patrick Boutilier <boutilpj@ednet.ns.ca> Fixes: 9667e9bb ("ipip: Add gro callbacks to ipip offload") Signed-off-by: Jesse Gross <jesse@kernel.org> --- net/ipv4/af_inet.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)