Patchwork [5/7] block: default to 0 minimal / optiomal I/O size

login
register
mail settings
Submitter Kevin Wolf
Date July 26, 2010, 2:01 p.m.
Message ID <1280152877-29037-6-git-send-email-kwolf@redhat.com>
Download mbox | patch
Permalink /patch/59918/
State New
Headers show

Comments

Kevin Wolf - July 26, 2010, 2:01 p.m.
From: Christoph Hellwig <hch@lst.de>

Currently we set them to 512 bytes unless manually specified.  Unforuntaly
some brain-dead partitioning tools create unaligned partitions if they
get low enough optiomal I/O size values, so don't report any at all
unless explicitly set.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block_int.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/block_int.h b/block_int.h
index 96ff4cf..f075a8c 100644
--- a/block_int.h
+++ b/block_int.h
@@ -243,7 +243,7 @@  static inline unsigned int get_physical_block_exp(BlockConf *conf)
                        _conf.logical_block_size, 512),                  \
     DEFINE_PROP_UINT16("physical_block_size", _state,                   \
                        _conf.physical_block_size, 512),                 \
-    DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 512),  \
-    DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 512)
+    DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0),  \
+    DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 0)
 
 #endif /* BLOCK_INT_H */