| Message ID | 1458135945-13385-4-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | f980ca3411bac50aa64be3c8fd4c436adfa7cb13 |
| Delegated to: | Tom Rini |
| Headers | show |
On Wed, Mar 16, 2016 at 07:45:33AM -0600, Simon Glass wrote: > The code flows through to the end of the function, so we don't need another > close() before this. Remove it. > > Reported-by: Coverity (CID: 138503) > > Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Tom Rini <trini@konsulko.com>
On Wed, Mar 16, 2016 at 07:45:33AM -0600, Simon Glass wrote: > The code flows through to the end of the function, so we don't need another > close() before this. Remove it. > > Reported-by: Coverity (CID: 138503) > > Signed-off-by: Simon Glass <sjg@chromium.org> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/tools/fit_image.c b/tools/fit_image.c index 31aa43c..8a93ea3 100644 --- a/tools/fit_image.c +++ b/tools/fit_image.c @@ -446,8 +446,6 @@ static int fit_extract_data(struct image_tool_params *params, const char *fname) ret = -EIO; goto err; } - close(fd); - ret = 0; err:
The code flows through to the end of the function, so we don't need another close() before this. Remove it. Reported-by: Coverity (CID: 138503) Signed-off-by: Simon Glass <sjg@chromium.org> --- tools/fit_image.c | 2 -- 1 file changed, 2 deletions(-)