Message ID | 1458134150-14067-1-git-send-email-a@unstable.cc |
---|---|
State | Changes Requested |
Headers | show |
Hi Antonio, Comments inline. Antonio Quartulli wrote: > TODO: hostapd does not work yet with r8188eu > > Signed-off-by: Antonio Quartulli <a@unstable.cc> > --- > package/boot/uboot-sunxi/Makefile | 8 +++++++- > Can you please split this into a series, and put the packages and the target-related changes into separate patches? > target/linux/sunxi/config-4.4 | 15 ++++++++++++++- > target/linux/sunxi/image/Makefile | 4 ++++ > target/linux/sunxi/profiles/orangepi_mini.mk | 19 +++++++++++++++++++ > 4 files changed, 44 insertions(+), 2 deletions(-) > create mode 100644 target/linux/sunxi/profiles/orangepi_mini.mk > > diff --git a/package/boot/uboot-sunxi/Makefile b/package/boot/uboot-sunxi/Makefile > index 8844c89..6faac2c 100644 > --- a/package/boot/uboot-sunxi/Makefile > +++ b/package/boot/uboot-sunxi/Makefile [snip] > --- a/target/linux/sunxi/config-4.4 > +++ b/target/linux/sunxi/config-4.4 > [snip] > +CONFIG_R8188EU=m > I have to slightly disagree here. The pcduino3 profile puts this into a module (kmod-net-rtl8188eu), what was the reason for not following that? > CONFIG_RATIONAL=y > # CONFIG_RCU_BOOST is not set > CONFIG_RCU_STALL_COMMON=y > @@ -435,7 +448,6 @@ CONFIG_SPI_MASTER=y > CONFIG_SPI_SUN4I=y > CONFIG_SPI_SUN6I=y > CONFIG_SRCU=y > -# CONFIG_STAGING is not set > CONFIG_STMMAC_ETH=y > CONFIG_STMMAC_PLATFORM=y > CONFIG_STRICT_DEVMEM=y > @@ -492,6 +504,7 @@ CONFIG_VT_CONSOLE=y > CONFIG_VT_CONSOLE_SLEEP=y > CONFIG_VT_HW_CONSOLE_BINDING=y > CONFIG_WATCHDOG_CORE=y > +# CONFIG_WILC1000_DRIVER is not set > # CONFIG_WQ_POWER_EFFICIENT_DEFAULT is not set > Just nitpicking, can you add these as a missing symbol into target/linux/generic/config-4.4 in the series? > CONFIG_XFRM_ALGO=y > CONFIG_XFRM_USER=y > diff --git a/target/linux/sunxi/image/Makefile b/target/linux/sunxi/image/Makefile > index bda690e..190cf02 100644 > --- a/target/linux/sunxi/image/Makefile > +++ b/target/linux/sunxi/image/Makefile > @@ -111,6 +111,10 @@ define Image/Build/Profile/orangepi_plus > $(call Image/Build/SDCard,$(1),sun8i-h3-orangepi-plus) > endef > > +define Image/Build/Profile/Orangepi_mini > + $(call Image/Build/SDCard,$(1),sun7i-a20-orangepi-mini) > +endef > + > define Image/Build > $(call Image/Build/$(1),$(1)) > $(call Image/Build/Profile/$(PROFILE),$(1)) > diff --git a/target/linux/sunxi/profiles/orangepi_mini.mk b/target/linux/sunxi/profiles/orangepi_mini.mk > new file mode 100644 > index 0000000..2d55acf > --- /dev/null > +++ b/target/linux/sunxi/profiles/orangepi_mini.mk > @@ -0,0 +1,19 @@ > +# > +# Copyright (C) 2016 OpenWrt.org > +# > +# This is free software, licensed under the GNU General Public License v2. > +# See /LICENSE for more information. > +# > + > +define Profile/Orangepi_mini > + NAME:=Orangepi_mini > + PACKAGES:=\ > + uboot-sunxi-Orangepi_mini kmod-ata-core kmod-ata-sunxi \ > + kmod-rtc-sunxi kmod-mac80211 kmod-net-rtl8188eu > +endef > Hmm. Can you please revisit the 8188 module then. :) > + > +define Profile/Orange Pi Mini/Description > + Package set optimized for the Xunlong Orange Pi Mini > +endef > + > +$(eval $(call Profile,Orangepi_mini)) > Thanks, Zoltan H
Hi Zoltan, thanks for your review! On Sat, Mar 19, 2016 at 12:53:32PM +0100, Zoltan HERPAI wrote: [..] > > package/boot/uboot-sunxi/Makefile | 8 +++++++- > > > Can you please split this into a series, and put the packages and the > target-related changes into separate patches? Sure, will do. > > > target/linux/sunxi/config-4.4 | 15 ++++++++++++++- > > target/linux/sunxi/image/Makefile | 4 ++++ > > target/linux/sunxi/profiles/orangepi_mini.mk | 19 +++++++++++++++++++ [..] > > > +CONFIG_R8188EU=m > > > I have to slightly disagree here. The pcduino3 profile puts this into a > module (kmod-net-rtl8188eu), what was the reason for not following that? I think I simply misunderstood how this works. I wanted to use kmod-net-rtl8188eu but I thought that the only way to make sure it was built was to also set it =m in the kernel. I'll have a look at pcduino3 to understand how this should be done. [..] > > +# CONFIG_WILC1000_DRIVER is not set > > # CONFIG_WQ_POWER_EFFICIENT_DEFAULT is not set > > > Just nitpicking, can you add these as a missing symbol into > target/linux/generic/config-4.4 in the series? eheh, yeah that'd be the right place. [..] > > +define Profile/Orangepi_mini > > + NAME:=Orangepi_mini > > + PACKAGES:=\ > > + uboot-sunxi-Orangepi_mini kmod-ata-core kmod-ata-sunxi \ > > + kmod-rtc-sunxi kmod-mac80211 kmod-net-rtl8188eu > > +endef > > > Hmm. Can you please revisit the 8188 module then. :) > yeah - as said above, I wanted to use kmod-net-rtl8188eu but I haven't found the right way to make sure it got compiled. I'll fix this. Thank you ! Cheers,
diff --git a/package/boot/uboot-sunxi/Makefile b/package/boot/uboot-sunxi/Makefile index 8844c89..6faac2c 100644 --- a/package/boot/uboot-sunxi/Makefile +++ b/package/boot/uboot-sunxi/Makefile @@ -94,6 +94,11 @@ define uboot/orangepi_plus TITLE:=U-Boot for Orange Pi Plus (H3) endef +define uboot/Orangepi_mini + TITLE:=U-Boot for Orange Pi Mini (A20) +endef + + UBOOTS:= \ A10-OLinuXino-Lime \ A13-OLinuXino \ @@ -110,7 +115,8 @@ UBOOTS:= \ Linksprite_pcDuino \ Linksprite_pcDuino3 \ Lamobo_R1 \ - orangepi_plus + orangepi_plus \ + Orangepi_mini define Package/uboot/template define Package/uboot-sunxi-$(1) diff --git a/target/linux/sunxi/config-4.4 b/target/linux/sunxi/config-4.4 index dbefd32..51cdaa8 100644 --- a/target/linux/sunxi/config-4.4 +++ b/target/linux/sunxi/config-4.4 @@ -1,3 +1,4 @@ +CONFIG_88EU_AP_MODE=y CONFIG_ADVISE_SYSCALLS=y # CONFIG_AHCI_SUNXI is not set CONFIG_ALIGNMENT_TRAP=y @@ -52,6 +53,7 @@ CONFIG_ARM_VIRT_EXT=y CONFIG_ATA=y CONFIG_ATAGS=y # CONFIG_ATA_SFF is not set +# CONFIG_ATH_CARDS is not set CONFIG_AUDIT=y # CONFIG_AUDITSYSCALL is not set CONFIG_AUDIT_GENERIC=y @@ -71,6 +73,14 @@ CONFIG_BOUNCE=y CONFIG_BUILD_BIN2C=y CONFIG_CACHE_L2X0=y CONFIG_CAN=y +CONFIG_CFG80211=m +CONFIG_CFG80211_CRDA_SUPPORT=y +# CONFIG_CFG80211_DEBUGFS is not set +# CONFIG_CFG80211_DEFAULT_PS is not set +# CONFIG_CFG80211_DEVELOPER_WARNINGS is not set +# CONFIG_CFG80211_INTERNAL_REGDB is not set +# CONFIG_CFG80211_REG_DEBUG is not set +CONFIG_CFG80211_WEXT=y CONFIG_CLKDEV_LOOKUP=y CONFIG_CLKSRC_MMIO=y CONFIG_CLKSRC_OF=y @@ -321,6 +331,7 @@ CONFIG_MODULES_USE_ELF_REL=y # CONFIG_MTD is not set CONFIG_MULTI_IRQ_HANDLER=y CONFIG_MUTEX_SPIN_ON_OWNER=y +# CONFIG_MWIFIEX is not set CONFIG_NAMESPACES=y CONFIG_NEED_DMA_MAP_STATE=y CONFIG_NEON=y @@ -328,6 +339,7 @@ CONFIG_NET_FLOW_LIMIT=y CONFIG_NET_NS=y CONFIG_NET_PTP_CLASSIFY=y CONFIG_NET_VENDOR_ALLWINNER=y +# CONFIG_NL80211_TESTMODE is not set CONFIG_NLS=y CONFIG_NO_BOOTMEM=y CONFIG_NO_HZ=y @@ -387,6 +399,7 @@ CONFIG_PTP_1588_CLOCK=y CONFIG_PWM=y CONFIG_PWM_SUN4I=y CONFIG_PWM_SYSFS=y +CONFIG_R8188EU=m CONFIG_RATIONAL=y # CONFIG_RCU_BOOST is not set CONFIG_RCU_STALL_COMMON=y @@ -435,7 +448,6 @@ CONFIG_SPI_MASTER=y CONFIG_SPI_SUN4I=y CONFIG_SPI_SUN6I=y CONFIG_SRCU=y -# CONFIG_STAGING is not set CONFIG_STMMAC_ETH=y CONFIG_STMMAC_PLATFORM=y CONFIG_STRICT_DEVMEM=y @@ -492,6 +504,7 @@ CONFIG_VT_CONSOLE=y CONFIG_VT_CONSOLE_SLEEP=y CONFIG_VT_HW_CONSOLE_BINDING=y CONFIG_WATCHDOG_CORE=y +# CONFIG_WILC1000_DRIVER is not set # CONFIG_WQ_POWER_EFFICIENT_DEFAULT is not set CONFIG_XFRM_ALGO=y CONFIG_XFRM_USER=y diff --git a/target/linux/sunxi/image/Makefile b/target/linux/sunxi/image/Makefile index bda690e..190cf02 100644 --- a/target/linux/sunxi/image/Makefile +++ b/target/linux/sunxi/image/Makefile @@ -111,6 +111,10 @@ define Image/Build/Profile/orangepi_plus $(call Image/Build/SDCard,$(1),sun8i-h3-orangepi-plus) endef +define Image/Build/Profile/Orangepi_mini + $(call Image/Build/SDCard,$(1),sun7i-a20-orangepi-mini) +endef + define Image/Build $(call Image/Build/$(1),$(1)) $(call Image/Build/Profile/$(PROFILE),$(1)) diff --git a/target/linux/sunxi/profiles/orangepi_mini.mk b/target/linux/sunxi/profiles/orangepi_mini.mk new file mode 100644 index 0000000..2d55acf --- /dev/null +++ b/target/linux/sunxi/profiles/orangepi_mini.mk @@ -0,0 +1,19 @@ +# +# Copyright (C) 2016 OpenWrt.org +# +# This is free software, licensed under the GNU General Public License v2. +# See /LICENSE for more information. +# + +define Profile/Orangepi_mini + NAME:=Orangepi_mini + PACKAGES:=\ + uboot-sunxi-Orangepi_mini kmod-ata-core kmod-ata-sunxi \ + kmod-rtc-sunxi kmod-mac80211 kmod-net-rtl8188eu +endef + +define Profile/Orange Pi Mini/Description + Package set optimized for the Xunlong Orange Pi Mini +endef + +$(eval $(call Profile,Orangepi_mini))
TODO: hostapd does not work yet with r8188eu Signed-off-by: Antonio Quartulli <a@unstable.cc> --- package/boot/uboot-sunxi/Makefile | 8 +++++++- target/linux/sunxi/config-4.4 | 15 ++++++++++++++- target/linux/sunxi/image/Makefile | 4 ++++ target/linux/sunxi/profiles/orangepi_mini.mk | 19 +++++++++++++++++++ 4 files changed, 44 insertions(+), 2 deletions(-) create mode 100644 target/linux/sunxi/profiles/orangepi_mini.mk