| Message ID | 1458129209-15449-1-git-send-email-afaerber@suse.de |
|---|---|
| State | Accepted, archived |
| Headers | show |
Hello Andreas, On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <afaerber@suse.de> wrote: > Drop #address-cells and #size-cells, which are not required by the > gpio-keys binding documentation, as button sub-nodes are not devices. > > Rename sub-nodes to avoid new dtc unit address warnings when copied. > > While at it, adopt the dashes convention for the node name. > > Reported-by: Julien Chauveau <chauveau.julien@gmail.com> > Cc: Julien Chauveau <chauveau.julien@gmail.com> > Cc: Javier Martinez Canillas <javier@dowhile0.org> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- Patch looks good to me. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Le 16 mars 2016 à 15:47, Javier Martinez Canillas <javier@dowhile0.org> a écrit : > > Hello Andreas, > > On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <afaerber@suse.de> wrote: >> Drop #address-cells and #size-cells, which are not required by the >> gpio-keys binding documentation, as button sub-nodes are not devices. >> >> Rename sub-nodes to avoid new dtc unit address warnings when copied. >> >> While at it, adopt the dashes convention for the node name. >> >> Reported-by: Julien Chauveau <chauveau.julien@gmail.com> >> Cc: Julien Chauveau <chauveau.julien@gmail.com> >> Cc: Javier Martinez Canillas <javier@dowhile0.org> >> Cc: Geert Uytterhoeven <geert@linux-m68k.org> >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> --- > > Patch looks good to me. > > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> I agree. Reviewed-by: Julien Chauveau <chauveau.julien@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 16, 2016 at 10:55:53PM +0100, Julien Chauveau wrote: > > > Le 16 mars 2016 à 15:47, Javier Martinez Canillas <javier@dowhile0.org> a écrit : > > > > Hello Andreas, > > > > On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <afaerber@suse.de> wrote: > >> Drop #address-cells and #size-cells, which are not required by the > >> gpio-keys binding documentation, as button sub-nodes are not devices. > >> > >> Rename sub-nodes to avoid new dtc unit address warnings when copied. > >> > >> While at it, adopt the dashes convention for the node name. > >> > >> Reported-by: Julien Chauveau <chauveau.julien@gmail.com> > >> Cc: Julien Chauveau <chauveau.julien@gmail.com> > >> Cc: Javier Martinez Canillas <javier@dowhile0.org> > >> Cc: Geert Uytterhoeven <geert@linux-m68k.org> > >> Signed-off-by: Andreas Färber <afaerber@suse.de> > >> --- > > > > Patch looks good to me. > > > > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > > I agree. > > Reviewed-by: Julien Chauveau <chauveau.julien@gmail.com> Applied, thank you.
On Wed, Mar 16, 2016 at 12:53:29PM +0100, Andreas Färber wrote: > Drop #address-cells and #size-cells, which are not required by the > gpio-keys binding documentation, as button sub-nodes are not devices. > > Rename sub-nodes to avoid new dtc unit address warnings when copied. > > While at it, adopt the dashes convention for the node name. > > Reported-by: Julien Chauveau <chauveau.julien@gmail.com> > Cc: Julien Chauveau <chauveau.julien@gmail.com> > Cc: Javier Martinez Canillas <javier@dowhile0.org> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Andreas Färber <afaerber@suse.de> Applied, thanks. Rob > --- > v1 -> v2: > * Changed node name from underscore to dash > * Inserted white lines > * Renamed sub-nodes (Geert, Julien) > > Documentation/devicetree/bindings/input/gpio-keys.txt | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt > index 21641236c095..a94940481e55 100644 > --- a/Documentation/devicetree/bindings/input/gpio-keys.txt > +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt > @@ -32,17 +32,17 @@ Optional subnode-properties: > > Example nodes: > > - gpio_keys { > + gpio-keys { > compatible = "gpio-keys"; > - #address-cells = <1>; > - #size-cells = <0>; > autorepeat; > - button@21 { > + > + up { > label = "GPIO Key UP"; > linux,code = <103>; > gpios = <&gpio1 0 1>; > }; > - button@22 { > + > + down { > label = "GPIO Key DOWN"; > linux,code = <108>; > interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; > -- > 2.6.2 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Rob, On Tue, Apr 19, 2016 at 6:13 PM, Rob Herring <robh@kernel.org> wrote: > On Wed, Mar 16, 2016 at 12:53:29PM +0100, Andreas Färber wrote: >> Drop #address-cells and #size-cells, which are not required by the >> gpio-keys binding documentation, as button sub-nodes are not devices. >> >> Rename sub-nodes to avoid new dtc unit address warnings when copied. >> >> While at it, adopt the dashes convention for the node name. >> >> Reported-by: Julien Chauveau <chauveau.julien@gmail.com> >> Cc: Julien Chauveau <chauveau.julien@gmail.com> >> Cc: Javier Martinez Canillas <javier@dowhile0.org> >> Cc: Geert Uytterhoeven <geert@linux-m68k.org> >> Signed-off-by: Andreas Färber <afaerber@suse.de> > > Applied, thanks. > Dmitry already applied this patch in the input tree. > Rob > Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt index 21641236c095..a94940481e55 100644 --- a/Documentation/devicetree/bindings/input/gpio-keys.txt +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt @@ -32,17 +32,17 @@ Optional subnode-properties: Example nodes: - gpio_keys { + gpio-keys { compatible = "gpio-keys"; - #address-cells = <1>; - #size-cells = <0>; autorepeat; - button@21 { + + up { label = "GPIO Key UP"; linux,code = <103>; gpios = <&gpio1 0 1>; }; - button@22 { + + down { label = "GPIO Key DOWN"; linux,code = <108>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
Drop #address-cells and #size-cells, which are not required by the gpio-keys binding documentation, as button sub-nodes are not devices. Rename sub-nodes to avoid new dtc unit address warnings when copied. While at it, adopt the dashes convention for the node name. Reported-by: Julien Chauveau <chauveau.julien@gmail.com> Cc: Julien Chauveau <chauveau.julien@gmail.com> Cc: Javier Martinez Canillas <javier@dowhile0.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Andreas Färber <afaerber@suse.de> --- v1 -> v2: * Changed node name from underscore to dash * Inserted white lines * Renamed sub-nodes (Geert, Julien) Documentation/devicetree/bindings/input/gpio-keys.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)