From patchwork Fri Jul 23 18:14:20 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Blue Swirl X-Patchwork-Id: 59827 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BA557B6EF3 for ; Sat, 24 Jul 2010 04:16:53 +1000 (EST) Received: from localhost ([127.0.0.1]:47588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OcMni-0005Gw-Qe for incoming@patchwork.ozlabs.org; Fri, 23 Jul 2010 14:16:50 -0400 Received: from [140.186.70.92] (port=48250 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OcMlg-0004Fk-Mx for qemu-devel@nongnu.org; Fri, 23 Jul 2010 14:14:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OcMld-0002bC-Ux for qemu-devel@nongnu.org; Fri, 23 Jul 2010 14:14:44 -0400 Received: from mail-qw0-f45.google.com ([209.85.216.45]:45031) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcMld-0002aq-PT for qemu-devel@nongnu.org; Fri, 23 Jul 2010 14:14:41 -0400 Received: by qwi4 with SMTP id 4so359849qwi.4 for ; Fri, 23 Jul 2010 11:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:from:date :message-id:subject:to:content-type; bh=vLg0WIi9H1XIttwzFhR6VbI4sytPDMNVQcP9Z4smwgk=; b=abfo/4Z4LPU1LCXdoa5fnrsyoxCNQRzi3BYw+vC5UJjMlidxBHt4F3RbLXu5kVh19k KWE2om/RkdJE/EGiWqnlbTdbB+DHXOfUG2LPfgiMbknTuSyOazf06T5kVJ4UDpAtWMuB 3F1lrxguWjcgugpO8/HcxF0M80VmVN6qnNu7Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=reFN/rSEPzLt8fUlCO6Ww3S5OsfxJicyL56fBMtYdilS4rDy+hBpgfiJFAI8p/oe47 V7zLIoilKDV+FPhIxmI0m1CzeL5WIQQT1nF5B/rxGbvsN3SVWcLZzMTdtbaCsf82Uhen waFJMqIjZrUDV6ESLIZ70NtWRoofjajabRp+o= Received: by 10.224.37.9 with SMTP id v9mr2955165qad.114.1279908880539; Fri, 23 Jul 2010 11:14:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.185.146 with HTTP; Fri, 23 Jul 2010 11:14:20 -0700 (PDT) From: Blue Swirl Date: Fri, 23 Jul 2010 18:14:20 +0000 Message-ID: To: qemu-devel X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Qemu-devel] Disk images deleted with -snapshot X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Somehow, one of my CD images disappeared after use. It seems to be a horrible bug with -snapshot: $ touch image.iso image2.iso $ qemu -cdrom image.iso -monitor stdio QEMU 0.12.50 monitor - type 'help' for more information (qemu) change ide1-cd0 image2.iso (qemu) change ide1-cd0 image.iso (qemu) q $ qemu -snapshot -cdrom image.iso -monitor stdio unlink(/tmp/vl.E5vyzl) in /src/qemu/block.c:466 QEMU 0.12.50 monitor - type 'help' for more information (qemu) change ide1-cd0 image2.iso unlink(image2.iso) in /src/qemu/block.c:466 (qemu) change ide1-cd0 image.iso unlink(image.iso) in /src/qemu/block.c:466 Could not open 'image.iso' (qemu) q $ ls image*.iso ls: cannot access image*.iso: No such file or directory #endif @@ -628,6 +629,7 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags, unlink_and_fail: if (bs->is_temporary) { + fprintf(stderr, "unlink(%s) in %s:%d\n", filename, __FILE__, __LINE__); unlink(filename); } return ret; @@ -647,6 +649,7 @@ void bdrv_close(BlockDriverState *bs) qemu_free(bs->opaque); #ifdef _WIN32 if (bs->is_temporary) { + fprintf(stderr, "unlink(%s) in %s:%d\n", filename, __FILE__, __LINE__); unlink(bs->filename); } #endif diff --git a/block.c b/block.c index f837876..21d5352 100644 --- a/block.c +++ b/block.c @@ -463,6 +463,7 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filename, #ifndef _WIN32 if (bs->is_temporary) { + fprintf(stderr, "unlink(%s) in %s:%d\n", filename, __FILE__, __LINE__); unlink(filename); }