| Message ID | 1458034150-10766-1-git-send-email-abrodkin@synopsys.com |
|---|---|
| State | Accepted |
| Headers | show |
Hello. On 3/15/2016 12:29 PM, Alexey Brodkin wrote: > Following commit broke DW GMAC functionality on AXS10x boards: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763 > > That's what happens on eth0 up: > --------------------------->8------------------------ > libphy: PHY stmmac-0:ffffffff not found > eth0: Could not attach to PHY > stmmac_open: Cannot attach to PHY (error: -19) > --------------------------->8------------------------ > > Simplest solution is to add PHY description in board's .dts. > And so we do here. > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Phil Reid <preid@electromag.com.au> > Cc: David S. Miller <davem@davemloft.net> > Cc: linux-kernel@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: stable@vger.kernel.org # 4.5.x > --- > arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi > index 44a578c..04b999e 100644 > --- a/arch/arc/boot/dts/axs10x_mb.dtsi > +++ b/arch/arc/boot/dts/axs10x_mb.dtsi > @@ -47,6 +47,14 @@ > clocks = <&apbclk>; > clock-names = "stmmaceth"; > max-speed = <100>; > + mdio0 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "snps,dwmac-mdio"; > + phy0: ethernet-phy@0 { The naming is inconsistent with the "reg" prop specified, should be @1. MBR, Sergei
Hi Sergei, On Tue, 2016-03-15 at 17:38 +0300, Sergei Shtylyov wrote: > Hello. > > On 3/15/2016 12:29 PM, Alexey Brodkin wrote: > > > > > Following commit broke DW GMAC functionality on AXS10x boards: > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763 > > > > That's what happens on eth0 up: > > --------------------------->8------------------------ > > libphy: PHY stmmac-0:ffffffff not found > > eth0: Could not attach to PHY > > stmmac_open: Cannot attach to PHY (error: -19) > > --------------------------->8------------------------ > > > > Simplest solution is to add PHY description in board's .dts. > > And so we do here. > > > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > > Cc: Rob Herring <robh@kernel.org> > > Cc: Phil Reid <preid@electromag.com.au> > > Cc: David S. Miller <davem@davemloft.net> > > Cc: linux-kernel@vger.kernel.org > > Cc: netdev@vger.kernel.org > > Cc: stable@vger.kernel.org # 4.5.x > > --- > > arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi > > index 44a578c..04b999e 100644 > > --- a/arch/arc/boot/dts/axs10x_mb.dtsi > > +++ b/arch/arc/boot/dts/axs10x_mb.dtsi > > @@ -47,6 +47,14 @@ > > clocks = <&apbclk>; > > clock-names = "stmmaceth"; > > max-speed = <100>; > > + mdio0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + compatible = "snps,dwmac-mdio"; > > + phy0: ethernet-phy@0 { > The naming is inconsistent with the "reg" prop specified, should be @1. Makes sense. Will re-send it with mentioned fix. -Alexey
diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi index 44a578c..04b999e 100644 --- a/arch/arc/boot/dts/axs10x_mb.dtsi +++ b/arch/arc/boot/dts/axs10x_mb.dtsi @@ -47,6 +47,14 @@ clocks = <&apbclk>; clock-names = "stmmaceth"; max-speed = <100>; + mdio0 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "snps,dwmac-mdio"; + phy0: ethernet-phy@0 { + reg = <1>; + }; + }; }; ehci@0x40000 {
Following commit broke DW GMAC functionality on AXS10x boards: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763 That's what happens on eth0 up: --------------------------->8------------------------ libphy: PHY stmmac-0:ffffffff not found eth0: Could not attach to PHY stmmac_open: Cannot attach to PHY (error: -19) --------------------------->8------------------------ Simplest solution is to add PHY description in board's .dts. And so we do here. Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Rob Herring <robh@kernel.org> Cc: Phil Reid <preid@electromag.com.au> Cc: David S. Miller <davem@davemloft.net> Cc: linux-kernel@vger.kernel.org Cc: netdev@vger.kernel.org Cc: stable@vger.kernel.org # 4.5.x --- arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)