From patchwork Mon Mar 14 18:34:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarkko Sakkinen X-Patchwork-Id: 597224 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qP5ym2vGCz9snk for ; Tue, 15 Mar 2016 05:35:12 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=sfs-ml-2.v29.ch3.sourceforge.com) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1afXKb-0005O6-Or; Mon, 14 Mar 2016 18:35:05 +0000 Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1afXKb-0005O0-1X for tpmdd-devel@lists.sourceforge.net; Mon, 14 Mar 2016 18:35:05 +0000 X-ACL-Warn: Received: from mga14.intel.com ([192.55.52.115]) by sog-mx-1.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1afXKY-0004X2-S2 for tpmdd-devel@lists.sourceforge.net; Mon, 14 Mar 2016 18:35:05 +0000 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 14 Mar 2016 11:34:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,336,1455004800"; d="scan'208";a="66181247" Received: from jtmcguir-mobl.ger.corp.intel.com (HELO localhost) ([10.252.4.78]) by fmsmga004.fm.intel.com with ESMTP; 14 Mar 2016 11:34:54 -0700 From: Jarkko Sakkinen To: Peter Huewe Date: Mon, 14 Mar 2016 20:34:46 +0200 Message-Id: <1457980486-29229-1-git-send-email-jarkko.sakkinen@linux.intel.com> X-Mailer: git-send-email 2.7.0 X-Spam-Score: -0.0 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-Headers-End: 1afXKY-0004X2-S2 Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove wmb()'s X-BeenThere: tpmdd-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Tpm Device Driver maintainance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: tpmdd-devel-bounces@lists.sourceforge.net wmbs are not neded as we use iowrite32(). Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm_crb.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c index a12b319..1cabe30 100644 --- a/drivers/char/tpm/tpm_crb.c +++ b/drivers/char/tpm/tpm_crb.c @@ -153,9 +153,6 @@ static int crb_send(struct tpm_chip *chip, u8 *buf, size_t len) memcpy_toio(priv->cmd, buf, len); - /* Make sure that cmd is populated before issuing start. */ - wmb(); - if (priv->flags & CRB_FL_CRB_START) iowrite32(cpu_to_le32(CRB_START_INVOKE), &priv->cca->start); @@ -171,9 +168,6 @@ static void crb_cancel(struct tpm_chip *chip) iowrite32(cpu_to_le32(CRB_CANCEL_INVOKE), &priv->cca->cancel); - /* Make sure that cmd is populated before issuing cancel. */ - wmb(); - if ((priv->flags & CRB_FL_ACPI_START) && crb_do_acpi_start(chip)) dev_err(&chip->dev, "ACPI Start failed\n");