diff mbox

[ANNOUNCE] ipset 6.28 released

Message ID alpine.DEB.2.10.1603131133010.18557@blackhole.kfki.hu
State RFC
Delegated to: Pablo Neira
Headers show

Commit Message

Jozsef Kadlecsik March 13, 2016, 10:33 a.m. UTC
On Sat, 12 Mar 2016, Jan Engelhardt wrote:

> >I'm happy to announce ipset 6.28 with a couple of important fixes, some 
> >compatibility improvements and corrections.
> >  - Support older pkg-config packages
> 
> Whatever you did, it broke.
> 
> [   51s] checking for libmnl... no
> [   51s] configure: error: in `/home/abuild/rpmbuild/BUILD/ipset-default-6.28':
> [   51s] configure: error: The pkg-config script could not be found or is too
> old.  Make sure it
> [   51s] is in your PATH or set the PKG_CONFIG environment variable to the full
> [   51s] path to pkg-config.

Does this patch help to solve the problem?



Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Jan Engelhardt March 13, 2016, 11:07 a.m. UTC | #1
On Sunday 2016-03-13 11:33, Jozsef Kadlecsik wrote:
>On Sat, 12 Mar 2016, Jan Engelhardt wrote:
>
>Does this patch help to solve the problem?
>
>diff --git a/configure.ac b/configure.ac
>index 1988836..b05646b 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -12,6 +12,8 @@ LT_INIT([dlopen])
> LT_CONFIG_LTDL_DIR([libltdl])
> LTDL_INIT([nonrecursive])
> 
>+PKG_PROG_PKG_CONFIG
>+
> dnl Shortcut: Linux supported alone
> case "$host" in
> *-*-linux* | *-*-uclinux*) ;;

It does.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Engelhardt March 13, 2016, 11:13 a.m. UTC | #2
On Sunday 2016-03-13 11:33, Jozsef Kadlecsik wrote:
>On Sat, 12 Mar 2016, Jan Engelhardt wrote:
>> >I'm happy to announce ipset 6.28 with a couple of important fixes, some 
>> >compatibility improvements and corrections.
>> >  - Support older pkg-config packages
>> 
>> it broke.

By the way, there is another issue. You are calling `modinfo` when make
install, but you are not passing  -b ${DESTDIR}, so it, too, fails
inside chroot buildroots. (because /lib/modules/V/kernel is empty;
ipset is in $DESTDIR/lib/modules/V/...)

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jozsef Kadlecsik March 13, 2016, 11:17 a.m. UTC | #3
On Sun, 13 Mar 2016, Jan Engelhardt wrote:

> On Sunday 2016-03-13 11:33, Jozsef Kadlecsik wrote:
> >On Sat, 12 Mar 2016, Jan Engelhardt wrote:
> >
> >Does this patch help to solve the problem?
> >
> >diff --git a/configure.ac b/configure.ac
> >index 1988836..b05646b 100644
> >--- a/configure.ac
> >+++ b/configure.ac
> >@@ -12,6 +12,8 @@ LT_INIT([dlopen])
> > LT_CONFIG_LTDL_DIR([libltdl])
> > LTDL_INIT([nonrecursive])
> > 
> >+PKG_PROG_PKG_CONFIG
> >+
> > dnl Shortcut: Linux supported alone
> > case "$host" in
> > *-*-linux* | *-*-uclinux*) ;;
> 
> It does.

Patch is out in the git tree, new package will be released after rewieving 
the patch race for the condition in ipset save, swap and delete.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jozsef Kadlecsik March 13, 2016, 11:29 a.m. UTC | #4
On Sun, 13 Mar 2016, Jan Engelhardt wrote:

> By the way, there is another issue. You are calling `modinfo` when make
> install, but you are not passing  -b ${DESTDIR}, so it, too, fails
> inside chroot buildroots. (because /lib/modules/V/kernel is empty;
> ipset is in $DESTDIR/lib/modules/V/...)

The variable DESTDIR is not defined by default, so some other trickery is 
required to get the chroot prefix dir path at that level, when `modinfo` 
is called. How do you call `configure` or `make`?

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Engelhardt March 13, 2016, 11:35 a.m. UTC | #5
On Sunday 2016-03-13 12:29, Jozsef Kadlecsik wrote:
>On Sun, 13 Mar 2016, Jan Engelhardt wrote:
>
>> By the way, there is another issue. You are calling `modinfo` when make
>> install, but you are not passing  -b ${DESTDIR}, so it, too, fails
>> inside chroot buildroots. (because /lib/modules/V/kernel is empty;
>> ipset is in $DESTDIR/lib/modules/V/...)
>
>The variable DESTDIR is not defined by default, so some other trickery is 
>required to get the chroot prefix dir path at that level, when `modinfo` 
>is called. How do you call `configure` or `make`?

./configure --host=x86_64-suse-linux-gnu --build=x86_64-suse-linux-gnu
--program-prefix= --disable-dependency-tracking --prefix=/usr
--exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc
--datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64
--libexecdir=/usr/lib --localstatedir=/var --sharedstatedir=/usr/com
--mandir=/usr/share/man --infodir=/usr/share/info --disable-dependency-tracking
--disable-static --with-kbuild=/usr/src/linux-obj/x86_64/default
--with-ksource=/usr/src/linux --includedir=/usr/include/ipset

make -j6 all modules

make -j6 install modules_install
DESTDIR=/home/abuild/rpmbuild/BUILDROOT/ipset-6.28-0.x86_64
INSTALL_MOD_PATH=/home/abuild/rpmbuild/BUILDROOT/ipset-6.28-0.x86_64 V=1

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/configure.ac b/configure.ac
index 1988836..b05646b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -12,6 +12,8 @@  LT_INIT([dlopen])
 LT_CONFIG_LTDL_DIR([libltdl])
 LTDL_INIT([nonrecursive])
 
+PKG_PROG_PKG_CONFIG
+
 dnl Shortcut: Linux supported alone
 case "$host" in
 *-*-linux* | *-*-uclinux*) ;;