| Message ID | 4C48BA82.6020904@mvista.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Min Zhang <mzhang@mvista.com> Date: Thu, 22 Jul 2010 14:39:14 -0700 > sysctl output ipv6 gc_elasticity and min_adv_mss as values divided by > HZ. However, they are not in unit of jiffies, since ip6_rt_min_advmss > refers to packet size and ip6_rt_fc_elasticity is used as scaler as in > expire>>ip6_rt_gc_elasticity, so replace the jiffies conversion > handler will regular handler for them. > > This has impact on scripts that are currently working assuming the > divide by HZ, will yield different results with this patch in place. > > Signed-off-by: Min Zhang <mzhang@mvista.com> Your email client corrupted your patch, turning tab characters into spaces. This makes your patch unusable. Please resubmit this patch properly so that I can use it. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 252d761..3b3de49 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2583,7 +2583,7 @@ ctl_table ipv6_route_table_template[] = { .data = &init_net.ipv6.sysctl.ip6_rt_gc_elasticity, .maxlen = sizeof(int), .mode = 0644, - .proc_handler = proc_dointvec_jiffies, + .proc_handler = proc_dointvec, }, { .procname = "mtu_expires", @@ -2597,7 +2597,7 @@ ctl_table ipv6_route_table_template[] = { .data = &init_net.ipv6.sysctl.ip6_rt_min_advmss, .maxlen = sizeof(int), .mode = 0644, - .proc_handler = proc_dointvec_jiffies, + .proc_handler = proc_dointvec, }, { .procname = "gc_min_interval_ms",
sysctl output ipv6 gc_elasticity and min_adv_mss as values divided by HZ. However, they are not in unit of jiffies, since ip6_rt_min_advmss refers to packet size and ip6_rt_fc_elasticity is used as scaler as in expire>>ip6_rt_gc_elasticity, so replace the jiffies conversion handler will regular handler for them. This has impact on scripts that are currently working assuming the divide by HZ, will yield different results with this patch in place. Signed-off-by: Min Zhang <mzhang@mvista.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html