[v3] gpio: gpio-pca953x: no interrupts with 4-bit devices
diff mbox

Message ID em477b04cd-60b3-47e8-ba4c-4e1b20ea3e6a@t410-5a
State New
Headers show

Commit Message

mrpace2@gmail.com March 10, 2016, 9:17 p.m. UTC
Ah, I didn't know about DIV_ROUND_UP(). I also didn't read Alexander's 
response correctly. Sorry about that. DIV_ROUND_UP() is essentially what 
he proposed, and it's also correct for ngpio==0.

So here's the third version of my trivial patch.

Signed-off-by: Frank Edelhaeuser <mrpace2 <at> gmail.com>
---


--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff -Nur a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
--- a/drivers/gpio/gpio-pca953x.c 2016-03-10 19:11:37.799908602 +0000
+++ b/drivers/gpio/gpio-pca953x.c 2016-03-10 19:11:09.635412539 +0000
@@ -86,7 +86,7 @@ 
  #define MAX_BANK 5
  #define BANK_SZ 8

-#define NBANK(chip) (chip->gpio_chip.ngpio / BANK_SZ)
+#define NBANK(chip) (DIV_ROUND_UP(chip->gpio_chip.ngpio, BANK_SZ))

  struct pca953x_chip {
   unsigned gpio_start;