From patchwork Thu Jul 22 14:47:01 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 59580 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2D554B70B9 for ; Fri, 23 Jul 2010 00:50:25 +1000 (EST) Received: from localhost ([127.0.0.1]:51366 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Obx5s-000552-Gq for incoming@patchwork.ozlabs.org; Thu, 22 Jul 2010 10:49:52 -0400 Received: from [140.186.70.92] (port=55399 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Obx3S-0003yX-1Z for qemu-devel@nongnu.org; Thu, 22 Jul 2010 10:47:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Obx3Q-0005Kh-Bx for qemu-devel@nongnu.org; Thu, 22 Jul 2010 10:47:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28187) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Obx3Q-0005Ka-3k for qemu-devel@nongnu.org; Thu, 22 Jul 2010 10:47:20 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6MElJ9a011932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 22 Jul 2010 10:47:19 -0400 Received: from localhost (ovpn-113-87.phx2.redhat.com [10.3.113.87]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6MElIuj003729; Thu, 22 Jul 2010 10:47:18 -0400 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Thu, 22 Jul 2010 11:47:01 -0300 Message-Id: <1279810021-11875-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1279810021-11875-1-git-send-email-lcapitulino@redhat.com> References: <1279810021-11875-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: armbru@redhat.com Subject: [Qemu-devel] [PATCH 2/2] QMP: Add a warning to the greeting message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This commit add the following new key to QMP's greeting message: "warning": "QMP is unstable, it will change soon!" The goal is to go beyond document warnings with regard to QMP's current state. Signed-off-by: Luiz Capitulino --- QMP/README | 2 +- monitor.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/QMP/README b/QMP/README index 8618c6f..cf158d2 100644 --- a/QMP/README +++ b/QMP/README @@ -61,7 +61,7 @@ $ telnet localhost 4444 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. -{"QMP": {"version": {"qemu": "0.12.50", "package": ""}, "capabilities": []}} +{"QMP": {"version": {"qemu": "0.12.50", "package": ""}, "capabilities": [], "warning": "QMP is unstable, it will change soon!"}} { "execute": "qmp_capabilities" } {"return": {}} { "execute": "query-version" } diff --git a/monitor.c b/monitor.c index 45fd482..c259b28 100644 --- a/monitor.c +++ b/monitor.c @@ -4384,7 +4384,8 @@ static QObject *get_qmp_greeting(void) QObject *ver; do_info_version(NULL, &ver); - return qobject_from_jsonf("{'QMP':{'version': %p,'capabilities': []}}",ver); + return qobject_from_jsonf("{ 'QMP': { 'version': %p, 'capabilities': [], " + "'warning': 'QMP is unstable, it will change soon!' } }", ver); } /**