From patchwork Thu Mar 10 13:46:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Senthil Kumar Selvaraj X-Patchwork-Id: 595789 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id CE1101402A8 for ; Fri, 11 Mar 2016 00:47:19 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=bf0DJMlw; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; q=dns; s=default; b=Apjc4Ly6FbPPWTUi6TAtzTcMRf8G35DF+ROU4uwUd3WSlt/8l+ 55GJ/cHJ3OM2d+OY/4PgTJfx+4Qg5ipNFeI5GzwJF1B6jQ5OKerwZHCYAX6JpKik 0MimN0YPwjAo+PNxN0ux/uUMdV9AdtDSkHDdqnrz/CZlQXirWkWWrsUKc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; s= default; bh=3n7I+zRUKfx2res/IPxLZf5Kjwc=; b=bf0DJMlwe1ttIzqLFv4a XmqcAOBmCzhJ5kFfzFncvG4QHSgRyl5wjCZg0S6WjfZ+N03nAxFyyt9PU+skGC8D 7vONlYJ7eJ1073chz/lvGHjeWvYP1JIAq3NI0HQTgzXyXWViNgVlzoTbGiYrYiYt jlOJ23Zfno4oW/Sqn7DamKg= Received: (qmail 110389 invoked by alias); 10 Mar 2016 13:47:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 110373 invoked by uid 89); 10 Mar 2016 13:47:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=kumar, Kumar, H*M:atmel, Reg X-HELO: eusmtp01.atmel.com Received: from eusmtp01.atmel.com (HELO eusmtp01.atmel.com) (212.144.249.243) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 10 Mar 2016 13:46:58 +0000 Received: from HNOCHT02.corp.atmel.com (10.161.30.162) by eusmtp01.atmel.com (10.161.101.31) with Microsoft SMTP Server (TLS) id 14.3.235.1; Thu, 10 Mar 2016 14:46:47 +0100 Received: from jaguar.corp.atmel.com.atmel.com (10.161.30.18) by HNOCHT02.corp.atmel.com (10.161.30.162) with Microsoft SMTP Server (TLS) id 14.3.235.1; Thu, 10 Mar 2016 14:46:52 +0100 User-agent: mu4e 0.9.13; emacs 24.5.1 From: Senthil Kumar Selvaraj To: GCC Patches CC: Denis Chertykov , Georg-Johann Lay Subject: [Patch, avr]Fix multiple ICE fallout of PR 69764 Date: Thu, 10 Mar 2016 19:16:15 +0530 Message-ID: <87pov2saxk.fsf@jaguar.corp.atmel.com> MIME-Version: 1.0 X-IsSubscribed: yes Hi, This patch fixes ~230 internal compiler errors that showed up after the fix for PR 69764. After the patch, target backends need to explicitly specify mode for operand 2 of shift and rotate patterns - see md.texi mod at https://gcc.gnu.org/viewcvs/gcc/trunk/gcc/doc/md.texi?r1=233358&r2=233613&pathrev=233613. The avr backend had VOIDmode as the mode for rotl SPN, and this patch sets it to the mode of the insn to fix the problem. Reg testing shows ICE fixes and no new failures. If this is ok, could someone commit please? I don't have commit access. Regards Senthil 2016-03-10 Senthil Kumar Selvaraj * config/avr/avr.md (rotl3): Set mode for operand 2. diff --git gcc/config/avr/avr.md gcc/config/avr/avr.md index ff26f2e..c988446 100644 --- gcc/config/avr/avr.md +++ gcc/config/avr/avr.md @@ -3351,7 +3351,7 @@ (define_expand "rotl3" [(parallel [(set (match_operand:HISI 0 "register_operand" "") (rotate:HISI (match_operand:HISI 1 "register_operand" "") - (match_operand:VOID 2 "const_int_operand" ""))) + (match_operand:HISI 2 "const_int_operand" ""))) (clobber (match_dup 3))])] "" {