| Message ID | 1457582861-20619-3-git-send-email-fcooper@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
On 10/03/16 06:07, Franklin S Cooper Jr wrote: > Recent patch series that updated the eDMA driver also updated the eDMA > bindings. > > The following patches forgot to update the DMA bindings for the GPMC node. > ARM: DTS: am33xx: Use the new DT bindings for the eDMA3 > ARM: DTS: am437x: Use the new DT bindings for the eDMA3 Instead of mentioning the patch subject here use the Fixes: tag. > > This patch corrects this so NAND with DMA prefetch can work. > > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> Please split this patch in to am33xx.dtsi and am4372.dtsi > --- > arch/arm/boot/dts/am33xx.dtsi | 2 +- > arch/arm/boot/dts/am4372.dtsi | 2 +- what about dm816x.dtsi and dm814x.dtsi? I suppose sdma based SoCs are not affected like this right? cheers, -roger > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index 1fafaad..97471d6 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -860,7 +860,7 @@ > ti,no-idle-on-init; > reg = <0x50000000 0x2000>; > interrupts = <100>; > - dmas = <&edma 52>; > + dmas = <&edma 52 0>; > dma-names = "rxtx"; > gpmc,num-cs = <7>; > gpmc,num-waitpins = <2>; > diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi > index 92068fb..2878b04 100644 > --- a/arch/arm/boot/dts/am4372.dtsi > +++ b/arch/arm/boot/dts/am4372.dtsi > @@ -884,7 +884,7 @@ > gpmc: gpmc@50000000 { > compatible = "ti,am3352-gpmc"; > ti,hwmods = "gpmc"; > - dmas = <&edma 52>; > + dmas = <&edma 52 0>; > dma-names = "rxtx"; > clocks = <&l3s_gclk>; > clock-names = "fck"; >
On 03/10/2016 06:51 AM, Roger Quadros wrote: > On 10/03/16 06:07, Franklin S Cooper Jr wrote: >> Recent patch series that updated the eDMA driver also updated the eDMA >> bindings. >> >> The following patches forgot to update the DMA bindings for the GPMC node. >> ARM: DTS: am33xx: Use the new DT bindings for the eDMA3 >> ARM: DTS: am437x: Use the new DT bindings for the eDMA3 > Instead of mentioning the patch subject here use the Fixes: tag. Ok. > >> This patch corrects this so NAND with DMA prefetch can work. >> >> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> > Please split this patch in to am33xx.dtsi and am4372.dtsi Ok > >> --- >> arch/arm/boot/dts/am33xx.dtsi | 2 +- >> arch/arm/boot/dts/am4372.dtsi | 2 +- > what about dm816x.dtsi and dm814x.dtsi? > > I suppose sdma based SoCs are not affected like this right? Correct. The updated driver was only eDMA. So sDMA bindings have not been changed. > > cheers, > -roger > >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi >> index 1fafaad..97471d6 100644 >> --- a/arch/arm/boot/dts/am33xx.dtsi >> +++ b/arch/arm/boot/dts/am33xx.dtsi >> @@ -860,7 +860,7 @@ >> ti,no-idle-on-init; >> reg = <0x50000000 0x2000>; >> interrupts = <100>; >> - dmas = <&edma 52>; >> + dmas = <&edma 52 0>; >> dma-names = "rxtx"; >> gpmc,num-cs = <7>; >> gpmc,num-waitpins = <2>; >> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi >> index 92068fb..2878b04 100644 >> --- a/arch/arm/boot/dts/am4372.dtsi >> +++ b/arch/arm/boot/dts/am4372.dtsi >> @@ -884,7 +884,7 @@ >> gpmc: gpmc@50000000 { >> compatible = "ti,am3352-gpmc"; >> ti,hwmods = "gpmc"; >> - dmas = <&edma 52>; >> + dmas = <&edma 52 0>; >> dma-names = "rxtx"; >> clocks = <&l3s_gclk>; >> clock-names = "fck"; >>
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 1fafaad..97471d6 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -860,7 +860,7 @@ ti,no-idle-on-init; reg = <0x50000000 0x2000>; interrupts = <100>; - dmas = <&edma 52>; + dmas = <&edma 52 0>; dma-names = "rxtx"; gpmc,num-cs = <7>; gpmc,num-waitpins = <2>; diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi index 92068fb..2878b04 100644 --- a/arch/arm/boot/dts/am4372.dtsi +++ b/arch/arm/boot/dts/am4372.dtsi @@ -884,7 +884,7 @@ gpmc: gpmc@50000000 { compatible = "ti,am3352-gpmc"; ti,hwmods = "gpmc"; - dmas = <&edma 52>; + dmas = <&edma 52 0>; dma-names = "rxtx"; clocks = <&l3s_gclk>; clock-names = "fck";
Recent patch series that updated the eDMA driver also updated the eDMA bindings. The following patches forgot to update the DMA bindings for the GPMC node. ARM: DTS: am33xx: Use the new DT bindings for the eDMA3 ARM: DTS: am437x: Use the new DT bindings for the eDMA3 This patch corrects this so NAND with DMA prefetch can work. Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> --- arch/arm/boot/dts/am33xx.dtsi | 2 +- arch/arm/boot/dts/am4372.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)