Patchwork [net-next] drivers/net/qlge: Remove duplicated initial DUMP_ macro entries

login
register
mail settings
Submitter Joe Perches
Date July 21, 2010, 9:19 p.m.
Message ID <1279747141.1909.22.camel@Joe-Laptop.home>
Download mbox | patch
Permalink /patch/59507/
State Accepted
Delegated to: David Miller
Headers show

Comments

Joe Perches - July 21, 2010, 9:19 p.m.
There are a couple of errors in the previous patch.
Two of the first DUMP_<foo> entries are duplicated.
Sorry, bad use of emacs macros...

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/qlge/qlge_dbg.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - July 21, 2010, 9:43 p.m.
From: Joe Perches <joe@perches.com>
Date: Wed, 21 Jul 2010 14:19:01 -0700

> There are a couple of errors in the previous patch.
> Two of the first DUMP_<foo> entries are duplicated.
> Sorry, bad use of emacs macros...
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Since I didn't push your original change out yet, I'll just add this
to the original commit.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/qlge/qlge_dbg.c b/drivers/net/qlge/qlge_dbg.c
index 9d9498b..4747492 100644
--- a/drivers/net/qlge/qlge_dbg.c
+++ b/drivers/net/qlge/qlge_dbg.c
@@ -1465,7 +1465,6 @@  void ql_dump_regs(struct ql_adapter *qdev)
 {
 	pr_err("reg dump for function #%d\n", qdev->func);
 	DUMP_REG(qdev, SYS);
-	DUMP_REG(qdev, SYS);
 	DUMP_REG(qdev, RST_FO);
 	DUMP_REG(qdev, FSC);
 	DUMP_REG(qdev, CSR);
@@ -1535,7 +1534,6 @@  void ql_dump_stat(struct ql_adapter *qdev)
 {
 	pr_err("%s: Enter\n", __func__);
 	DUMP_STAT(qdev, tx_pkts);
-	DUMP_STAT(qdev, tx_pkts);
 	DUMP_STAT(qdev, tx_bytes);
 	DUMP_STAT(qdev, tx_mcast_pkts);
 	DUMP_STAT(qdev, tx_bcast_pkts);