diff mbox

cxl: Remove dead code

Message ID 1457524393-6717-1-git-send-email-fbarrat@linux.vnet.ibm.com (mailing list archive)
State Accepted
Headers show

Commit Message

Frederic Barrat March 9, 2016, 11:53 a.m. UTC
Function cxl_get_phys_dev() was removed from the kernel API by a
previous patch, but it's actually dead code. Remove it.

Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
---
 drivers/misc/cxl/api.c | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Ian Munsie March 9, 2016, 11:22 p.m. UTC | #1
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Andrew Donnellan March 9, 2016, 11:35 p.m. UTC | #2
On 09/03/16 22:53, Frederic Barrat wrote:
> Function cxl_get_phys_dev() was removed from the kernel API by a
> previous patch, but it's actually dead code. Remove it.
>
> Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>

For those playing along at home, this applies on top of the cxl PowerVM 
series.

Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Michael Neuling March 9, 2016, 11:59 p.m. UTC | #3
On Wed, 2016-03-09 at 12:53 +0100, Frederic Barrat wrote:
> Function cxl_get_phys_dev() was removed from the kernel API by a
> previous patch, but it's actually dead code. Remove it.
> 
> Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>

Acked-by: Michael Neuling <mikey@neuling.org>

> ---
>  drivers/misc/cxl/api.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
> index 2107c94..8075823 100644
> --- a/drivers/misc/cxl/api.c
> +++ b/drivers/misc/cxl/api.c
> @@ -68,15 +68,6 @@ struct cxl_context *cxl_get_context(struct pci_dev
> *dev)
>  }
>  EXPORT_SYMBOL_GPL(cxl_get_context);
>  
> -struct device *cxl_get_phys_dev(struct pci_dev *dev)
> -{
> -	struct cxl_afu *afu;
> -
> -	afu = cxl_pci_to_afu(dev);
> -
> -	return afu->adapter->dev.parent;
> -}
> -
>  int cxl_release_context(struct cxl_context *ctx)
>  {
>  	if (ctx->status >= STARTED)
Michael Ellerman April 11, 2016, 12:35 p.m. UTC | #4
On Wed, 2016-09-03 at 11:53:13 UTC, Frederic Barrat wrote:
> Function cxl_get_phys_dev() was removed from the kernel API by a
> previous patch, but it's actually dead code. Remove it.
> 
> Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
> Acked-by: Ian Munsie <imunsie@au1.ibm.com>
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Acked-by: Michael Neuling <mikey@neuling.org>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/d88e397f12ba0c8c672952c471

cheers
diff mbox

Patch

diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
index 2107c94..8075823 100644
--- a/drivers/misc/cxl/api.c
+++ b/drivers/misc/cxl/api.c
@@ -68,15 +68,6 @@  struct cxl_context *cxl_get_context(struct pci_dev *dev)
 }
 EXPORT_SYMBOL_GPL(cxl_get_context);
 
-struct device *cxl_get_phys_dev(struct pci_dev *dev)
-{
-	struct cxl_afu *afu;
-
-	afu = cxl_pci_to_afu(dev);
-
-	return afu->adapter->dev.parent;
-}
-
 int cxl_release_context(struct cxl_context *ctx)
 {
 	if (ctx->status >= STARTED)