Patchwork [3/3] remove pointless if from vl.c

login
register
mail settings
Submitter jschopp@austin.ibm.com
Date July 21, 2010, 8:05 p.m.
Message ID <1279742717-10804-4-git-send-email-jschopp@austin.ibm.com>
Download mbox | patch
Permalink /patch/59493/
State New
Headers show

Comments

jschopp@austin.ibm.com - July 21, 2010, 8:05 p.m.
We already set sockets to nonzero in the code above.
So this if statement always evaluates true.  Remove it.

Signed-off-by: Joel Schopp <jschopp@austin.ibm.com>
---
 vl.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

Patch

diff --git a/vl.c b/vl.c
index 8a5de9f..a0c28b6 100644
--- a/vl.c
+++ b/vl.c
@@ -801,9 +801,7 @@  static void smp_parse(const char *optarg)
             threads = threads > 0 ? threads : 1;
             cores = smp / (sockets * threads);
         } else {
-            if (sockets) {
-                threads = smp / (cores * sockets);
-            }
+            threads = smp / (cores * sockets);
         }
     }
     smp_cpus = smp;