| Message ID | 1457489509-5680-1-git-send-email-linus.walleij@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Wed, Mar 09, 2016 at 09:11:49AM +0700, Linus Walleij wrote: > The pxa2xxx fails some automated builds because of unexported > symbols. > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> There is 3a5242e648a8d009f0e0fd47867592e5265374b6 in linus/master which does a part of this patch already. Apart from that I don't understand the patch. The only user of pxa2xx_pinctrl_init is drivers/pinctrl/pxa/pinctrl-pxa27x.c[1] and this is built into the same module as pinctrl-pxa2xx.o. So without testing I wonder in which configuration this fails to build. Best regards Uwe [1] git grep -E pxa2xx_pinctrl_\(in\|ex\)it next/master git grep -E pxa2xx_pinctrl_\(in\|ex\)it linus/master
diff --git a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c index d90e205cf809..f553313bc2ef 100644 --- a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c +++ b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c @@ -426,6 +426,7 @@ int pxa2xx_pinctrl_init(struct platform_device *pdev, return 0; } +EXPORT_SYMBOL_GPL(pxa2xx_pinctrl_init); int pxa2xx_pinctrl_exit(struct platform_device *pdev) { @@ -434,3 +435,4 @@ int pxa2xx_pinctrl_exit(struct platform_device *pdev) pinctrl_unregister(pctl->pctl_dev); return 0; } +EXPORT_SYMBOL_GPL(pxa2xx_pinctrl_exit);
The pxa2xxx fails some automated builds because of unexported symbols. Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/pinctrl/pxa/pinctrl-pxa2xx.c | 2 ++ 1 file changed, 2 insertions(+)