Patchwork [ARM,PING] : Remove superfluous test in arm_function_arg

login
register
mail settings
Submitter John Tytgat
Date July 21, 2010, noon
Message ID <527b493a51.Jo@hobbes.bass-software.com>
Download mbox | patch
Permalink /patch/59434/
State New
Headers show

Comments

John Tytgat - July 21, 2010, noon
In message <678f613751.Jo@hobbes.bass-software.com>
          John Tytgat <John.Tytgat@aaug.net> wrote:

> Attached patch removes in arm_function_arg() a superfluous test on one
> of its parameters as that test is already done at the beginning of the
> routine and the parameter doesn't change during the function.

Gentle reminder ping.

In the meanwhile I've found another superfluous test in
arm_override_options().  Updated patch attached.

gcc/

John Tytgat  <John.Tytgat@aaug.net>

	* config/arm/arm.c (arm_function_arg): Remove superfluous test.
	(arm_override_options): Likewise.

Please commit after positive review.

John.
John Tytgat - July 31, 2010, 2:02 p.m.
ARM maintainers,

2nd ping for:

  <URL:http://gcc.gnu.org/ml/gcc-patches/2010-07/msg01640.html>

Thanks,
John.
Richard Earnshaw - July 31, 2010, 2:28 p.m.
On Wed, 2010-07-21 at 13:00 +0100, John Tytgat wrote:
> In message <678f613751.Jo@hobbes.bass-software.com>
>           John Tytgat <John.Tytgat@aaug.net> wrote:
> 
> > Attached patch removes in arm_function_arg() a superfluous test on one
> > of its parameters as that test is already done at the beginning of the
> > routine and the parameter doesn't change during the function.
> 
> Gentle reminder ping.
> 
> In the meanwhile I've found another superfluous test in
> arm_override_options().  Updated patch attached.
> 
> gcc/
> 
> John Tytgat  <John.Tytgat@aaug.net>
> 
> 	* config/arm/arm.c (arm_function_arg): Remove superfluous test.
> 	(arm_override_options): Likewise.
> 

Checked in, thanks.

R.

Patch

Index: config/arm/arm.c
===================================================================
--- config/arm/arm.c	(revision 162370)
+++ config/arm/arm.c	(working copy)
@@ -1526,9 +1526,6 @@ 
   if (TARGET_ARM && TARGET_CALLEE_INTERWORKING)
     warning (0, "enabling callee interworking support is only meaningful when compiling for the Thumb");
 
-  if (TARGET_ARM && TARGET_CALLER_INTERWORKING)
-    warning (0, "enabling caller interworking support is only meaningful when compiling for the Thumb");
-
   if (TARGET_APCS_STACK && !TARGET_APCS_FRAME)
     {
       warning (0, "-mapcs-stack-check incompatible with -mno-apcs-frame");
@@ -4479,10 +4476,6 @@ 
       && arm_needs_doubleword_align (mode, type))
     pcum->nregs++;
 
-  if (mode == VOIDmode)
-    /* Pick an arbitrary value for operand 2 of the call insn.  */
-    return const0_rtx;
-
   /* Only allow splitting an arg between regs and memory if all preceding
      args were allocated to regs.  For args passed by reference we only count
      the reference pointer.  */