Patchwork [1/2] sysfs: sysfs_delete_link handle symlinks from untagged to tagged directories.

login
register
mail settings
Submitter Eric W. Biederman
Date July 21, 2010, 5:10 a.m.
Message ID <m1vd894dy5.fsf_-_@fess.ebiederm.org>
Download mbox | patch
Permalink /patch/59401/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Eric W. Biederman - July 21, 2010, 5:10 a.m.
This happens for network devices when SYSFS_DEPRECATED is enabled.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 fs/sysfs/symlink.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c
index 44bca5f..6603833 100644
--- a/fs/sysfs/symlink.c
+++ b/fs/sysfs/symlink.c
@@ -135,7 +135,7 @@  void sysfs_delete_link(struct kobject *kobj, struct kobject *targ,
 {
 	const void *ns = NULL;
 	spin_lock(&sysfs_assoc_lock);
-	if (targ->sd)
+	if (targ->sd && sysfs_ns_type(kobj->sd))
 		ns = targ->sd->s_ns;
 	spin_unlock(&sysfs_assoc_lock);
 	sysfs_hash_and_remove(kobj->sd, ns, name);