Message ID | m34ofucxes.fsf@linux.vnet.ibm.com |
---|---|
State | Rejected, archived |
Headers | show |
On Tuesday 20 July 2010 11:31:07 Aneesh Kumar K. V wrote: > We need to update ACL4_VALID_FLAGS to now consider ACL4_MASKED as a > valid flag. This is also needed for userspace. Good point, I missed that. > On a related note, should we move ACL4_MASKED and ACL4_POSIX_MAPPED to > be the higher bits ? That would make sure we will be able to accomodate > new flag value NFSv4 define. That makes sense, except that ACL4_POSIX_MAPPED hasn't entered the scene in the patches posted here, and I'm still not convinced that we'll actually need it. Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 20 Jul 2010 12:11:53 +0200, Andreas Gruenbacher <agruen@suse.de> wrote: > On Tuesday 20 July 2010 11:31:07 Aneesh Kumar K. V wrote: > > We need to update ACL4_VALID_FLAGS to now consider ACL4_MASKED as a > > valid flag. This is also needed for userspace. > > Good point, I missed that. I updated the patch and will push the change to korg after running some test. > > > On a related note, should we move ACL4_MASKED and ACL4_POSIX_MAPPED to > > be the higher bits ? That would make sure we will be able to accomodate > > new flag value NFSv4 define. > > That makes sense, except that ACL4_POSIX_MAPPED hasn't entered the scene in > the patches posted here, and I'm still not convinced that we'll actually need > it. > The userspace change did result in a different output for the below ex: richacl --set 'flags:a 101:w::deny 101:rw::allow 101:w:a:deny 101:rw:a:allow' f this now gives /mnt/d# richacl --get --numeric f f: flags:a 101:-w-----------::deny 101:rw-----------::allow 101:-w-----------:a:deny 101:rw-----------:a:allow that 'w' in rw::allow is redundant, because we have a deny entry before. -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 20 July 2010 17:23:36 Aneesh Kumar K. V wrote:
> The userspace change did result in a different output [...]
Yes, this is expected -- we now leave acls alone more often.
Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/richacl.h b/include/linux/richacl.h index 929cc32..ff3c12b 100644 --- a/include/linux/richacl.h +++ b/include/linux/richacl.h @@ -50,16 +50,17 @@ struct richacl { /* a_flags values */ #define ACL4_AUTO_INHERIT 0x01 #define ACL4_PROTECTED 0x02 -/*#define ACL4_DEFAULTED 0x04*/ -#define ACL4_MASKED 0x08 -#define ACL4_POSIX_MAPPED 0x10 +#define ACL4_DEFAULTED 0x04 +/* flag value defined by Richacl */ +#define ACL4_MASKED 0x40 +#define ACL4_POSIX_MAPPED 0x80 #define ACL4_VALID_FLAGS ( \ ACL4_AUTO_INHERIT | \ ACL4_PROTECTED | \ + ACL4_MASKED | \ ACL4_POSIX_MAPPED) - /* e_type values */ #define ACE4_ACCESS_ALLOWED_ACE_TYPE 0x0000 #define ACE4_ACCESS_DENIED_ACE_TYPE 0x0001