| Message ID | 1457344097-20448-1-git-send-email-nicolas.cavallari@green-communications.fr |
|---|---|
| State | Accepted |
| Commit | cc2ded05bd588f29f8094db8f593e56f52f13299 |
| Headers | show |
>>>>> "Nicolas" == Nicolas Cavallari <nicolas.cavallari@green-communications.fr> writes: > The default syslog parameters are to keep only 200-400 KiB of logs, > which is very few if there is a spammy daemon on the system, or a daemon > that fails and then spams errors that hides the original problem. > Make S01logging source a /etc/default/logging file where these > parameters can be overridden. > Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr> Committed, thanks.
diff --git a/package/busybox/S01logging b/package/busybox/S01logging index a72c69d..4632a4c 100644 --- a/package/busybox/S01logging +++ b/package/busybox/S01logging @@ -3,10 +3,14 @@ # Start logging # +SYSLOGD_ARGS=-n +KLOGD_ARGS=-n +[ -r /etc/default/logging ] && . /etc/default/logging + start() { printf "Starting logging: " - start-stop-daemon -b -S -q -m -p /var/run/syslogd.pid --exec /sbin/syslogd -- -n - start-stop-daemon -b -S -q -m -p /var/run/klogd.pid --exec /sbin/klogd -- -n + start-stop-daemon -b -S -q -m -p /var/run/syslogd.pid --exec /sbin/syslogd -- $SYSLOGD_ARGS + start-stop-daemon -b -S -q -m -p /var/run/klogd.pid --exec /sbin/klogd -- $KLOGD_ARGS echo "OK" }
The default syslog parameters are to keep only 200-400 KiB of logs, which is very few if there is a spammy daemon on the system, or a daemon that fails and then spams errors that hides the original problem. Make S01logging source a /etc/default/logging file where these parameters can be overridden. Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr> --- package/busybox/S01logging | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)