diff mbox

rtc: hym8563: fix invalid year calculation

Message ID 1457257437-18975-1-git-send-email-al.kochet@gmail.com
State Accepted
Headers show

Commit Message

Alexander Kochetkov March 6, 2016, 9:43 a.m. UTC
Year field must be in BCD format, according to
hym8563 datasheet.

Due to the bug year 2016 became 2010.

Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
---
 drivers/rtc/rtc-hym8563.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexandre Belloni March 10, 2016, 10:42 p.m. UTC | #1
On 06/03/2016 at 12:43:57 +0300, Alexander Kochetkov wrote :
> Year field must be in BCD format, according to
> hym8563 datasheet.
> 
> Due to the bug year 2016 became 2010.
> 
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
> ---
>  drivers/rtc/rtc-hym8563.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Applied, thanks.
diff mbox

Patch

diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c
index 097325d..b1b4746 100644
--- a/drivers/rtc/rtc-hym8563.c
+++ b/drivers/rtc/rtc-hym8563.c
@@ -144,7 +144,7 @@  static int hym8563_rtc_set_time(struct device *dev, struct rtc_time *tm)
 	 * it does not seem to carry it over a subsequent write/read.
 	 * So we'll limit ourself to 100 years, starting at 2000 for now.
 	 */
-	buf[6] = tm->tm_year - 100;
+	buf[6] = bin2bcd(tm->tm_year - 100);
 
 	/*
 	 * CTL1 only contains TEST-mode bits apart from stop,