gpio: xgene: Fix kconfig for standby GIPO contoller
diff mbox

Message ID 1457089198-27171-1-git-send-email-mbrugger@suse.com
State New
Headers show

Commit Message

Matthias Brugger March 4, 2016, 10:59 a.m. UTC
The standby GPIO controller can be used as a interrupt controller.
Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
a compilation error:

drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has no member named 'irqdomain'
  priv->gc.irqdomain = priv->irq_domain;
          ^
scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio-xgene-sb.o' failed
make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1

Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as interrupt controller"
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Quan Nguyen March 8, 2016, 4:29 a.m. UTC | #1
On Fri, Mar 4, 2016 at 5:59 PM, Matthias Brugger <mbrugger@suse.com> wrote:
> The standby GPIO controller can be used as a interrupt controller.
> Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
> a compilation error:
>
> drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
> drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has no member named 'irqdomain'
>   priv->gc.irqdomain = priv->irq_domain;
>           ^
> scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio-xgene-sb.o' failed
> make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1
>
> Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as interrupt controller"
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
>  drivers/gpio/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>

Acked-by: Quan Nguyen <qnguyen@apm.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij March 11, 2016, 4:01 p.m. UTC | #2
On Fri, Mar 4, 2016 at 5:59 PM, Matthias Brugger <mbrugger@suse.com> wrote:

> The standby GPIO controller can be used as a interrupt controller.
> Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
> a compilation error:
>
> drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
> drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has no member named 'irqdomain'
>   priv->gc.irqdomain = priv->irq_domain;
>           ^
> scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio-xgene-sb.o' failed
> make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1
>
> Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as interrupt controller"
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>

Quan's patch exporting the symbols has been merged by tglx
so dropping this.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Matthias Brugger March 11, 2016, 8:03 p.m. UTC | #3
On Fri, 2016-03-11 at 23:01 +0700, Linus Walleij wrote:
> On Fri, Mar 4, 2016 at 5:59 PM, Matthias Brugger <mbrugger@suse.com>
> wrote:
> 
> > The standby GPIO controller can be used as a interrupt controller.
> > Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
> > a compilation error:
> > 
> > drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
> > drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has
> > no member named 'irqdomain'
> >   priv->gc.irqdomain = priv->irq_domain;
> >           ^
> > scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio
> > -xgene-sb.o' failed
> > make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1
> > 
> > Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as
> > interrupt controller"
> > Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> 
> Quan's patch exporting the symbols has been merged by tglx
> so dropping this.
> 

Thanks for the info.

Actually this is v1 [1] of the patch, which just addresses the
GPIOLIB_IRQCHIP problem?
With Quan's patch this should still be present.

[1] https://patchwork.kernel.org/patch/8502401/
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij March 16, 2016, noon UTC | #4
On Fri, Mar 11, 2016 at 9:03 PM, Matthias Brugger <mbrugger@suse.com> wrote:
> On Fri, 2016-03-11 at 23:01 +0700, Linus Walleij wrote:
>> On Fri, Mar 4, 2016 at 5:59 PM, Matthias Brugger <mbrugger@suse.com>
>> wrote:
>>
>> > The standby GPIO controller can be used as a interrupt controller.
>> > Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
>> > a compilation error:
>> >
>> > drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
>> > drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has
>> > no member named 'irqdomain'
>> >   priv->gc.irqdomain = priv->irq_domain;
>> >           ^
>> > scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio
>> > -xgene-sb.o' failed
>> > make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1
>> >
>> > Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as
>> > interrupt controller"
>> > Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>>
>> Quan's patch exporting the symbols has been merged by tglx
>> so dropping this.
>>
>
> Thanks for the info.
>
> Actually this is v1 [1] of the patch, which just addresses the
> GPIOLIB_IRQCHIP problem?
> With Quan's patch this should still be present.

Ah sorry I screwed up here and confused the patches.

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 619767b..d9d6cfe 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -452,6 +452,7 @@  config GPIO_XGENE_SB
 	tristate "APM X-Gene GPIO standby controller support"
 	depends on ARCH_XGENE && OF_GPIO
 	select GPIO_GENERIC
+	select GPIOLIB_IRQCHIP
 	help
 	  This driver supports the GPIO block within the APM X-Gene
 	  Standby Domain. Say yes here to enable the GPIO functionality.