diff mbox

phy: remove documentation of removed member addr of phy_device structure

Message ID 1457010748-2584-1-git-send-email-clabbe.montjoie@gmail.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Corentin Labbe March 3, 2016, 1:12 p.m. UTC
Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed
the addr member of the phy_device structure.
This patch remove the documentation about that member.

Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
 include/linux/phy.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Andrew Lunn March 3, 2016, 3:14 p.m. UTC | #1
On Thu, Mar 03, 2016 at 02:12:28PM +0100, LABBE Corentin wrote:
> Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed
> the addr member of the phy_device structure.
> This patch remove the documentation about that member.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>

Hi Corentin

The patch also removed bus and dev which are documented.  Could you
please expand you patch to remove those as well?

Thanks
	Andrew

> ---
>  include/linux/phy.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index d6f3641..e14569e 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -338,7 +338,6 @@ struct phy_c45_device_ids {
>   * suspended: Set to true if this phy has been suspended successfully.
>   * state: state of the PHY for management purposes
>   * dev_flags: Device-specific flags used by the PHY driver.
> - * addr: Bus address of PHY
>   * link_timeout: The number of timer firings to wait before the
>   * giving up on the current attempt at acquiring a link
>   * irq: IRQ number of the PHY's interrupt (-1 if none)
> -- 
> 2.4.10
>
Corentin Labbe March 3, 2016, 3:46 p.m. UTC | #2
On Thu, Mar 03, 2016 at 04:14:19PM +0100, Andrew Lunn wrote:
> On Thu, Mar 03, 2016 at 02:12:28PM +0100, LABBE Corentin wrote:
> > Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed
> > the addr member of the phy_device structure.
> > This patch remove the documentation about that member.
> > 
> > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> 
> Hi Corentin
> 
> The patch also removed bus and dev which are documented.  Could you
> please expand you patch to remove those as well?
> 
> Thanks
> 	Andrew
> 

Yes, I will send a v2 soon.

Regards

LABBE Corentin
diff mbox

Patch

diff --git a/include/linux/phy.h b/include/linux/phy.h
index d6f3641..e14569e 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -338,7 +338,6 @@  struct phy_c45_device_ids {
  * suspended: Set to true if this phy has been suspended successfully.
  * state: state of the PHY for management purposes
  * dev_flags: Device-specific flags used by the PHY driver.
- * addr: Bus address of PHY
  * link_timeout: The number of timer firings to wait before the
  * giving up on the current attempt at acquiring a link
  * irq: IRQ number of the PHY's interrupt (-1 if none)