diff mbox

kernel crash with lite-on sata controller Dell XPS 13 9343

Message ID 20160302152559.GA4282@mtj.duckdns.org
State Not Applicable
Delegated to: David Miller
Headers show

Commit Message

Tejun Heo March 2, 2016, 3:25 p.m. UTC
Hello, Carolin.

On Wed, Mar 02, 2016 at 09:46:36AM +0100, Carolin Latze wrote:
> please see attached screen capture. If there is any better way to capture
> those logs than taking pictures, please let me know

Heh, so there have been quite a few cases where device locks up after
a lot of NCQ commands are issued and/or data transfer is taking place
at high rate but device locking up on plain WRITE_DMA_EXT is pretty
new.  Hmmm.... Does the following patch make any difference?

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Carolin Latze March 14, 2016, 4:02 p.m. UTC | #1
Hi Tejun

just a quick update from my side: I did patch the rc5 kernel yesterday 
(I am aware that there is a newer one but when you sent the patch, rc5 
was recent so I wanted to be on the safe side). There is a little typo 
on the "dma_boundary" line, the trailing comma is missing. But other 
than that, the patching went smoothly. Since then I reboot whenever I 
can. So far 15-20 times and no issue up until now. I will keep rebooting 
very often for the next days and keep you posted.

best regards
Carolin

On 02.03.2016 16:25, Tejun Heo wrote:
> Hello, Carolin.
>
> On Wed, Mar 02, 2016 at 09:46:36AM +0100, Carolin Latze wrote:
>> please see attached screen capture. If there is any better way to capture
>> those logs than taking pictures, please let me know
> Heh, so there have been quite a few cases where device locks up after
> a lot of NCQ commands are issued and/or data transfer is taking place
> at high rate but device locking up on plain WRITE_DMA_EXT is pretty
> new.  Hmmm.... Does the following patch make any difference?
>
> diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h
> index 45586c1..95c4d5c 100644
> --- a/drivers/ata/ahci.h
> +++ b/drivers/ata/ahci.h
> @@ -366,8 +366,8 @@ extern struct device_attribute *ahci_sdev_attrs[];
>   #define AHCI_SHT(drv_name)						\
>   	ATA_NCQ_SHT(drv_name),						\
>   	.can_queue		= AHCI_MAX_CMDS - 1,			\
> -	.sg_tablesize		= AHCI_MAX_SG,				\
> -	.dma_boundary		= AHCI_DMA_BOUNDARY,			\
> +	.sg_tablesize		= LIBATA_MAX_PRD,			\
> +	.dma_boundary		= ATA_DMA_BOUNDARY			\
>   	.shost_attrs		= ahci_shost_attrs,			\
>   	.sdev_attrs		= ahci_sdev_attrs
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h
index 45586c1..95c4d5c 100644
--- a/drivers/ata/ahci.h
+++ b/drivers/ata/ahci.h
@@ -366,8 +366,8 @@  extern struct device_attribute *ahci_sdev_attrs[];
 #define AHCI_SHT(drv_name)						\
 	ATA_NCQ_SHT(drv_name),						\
 	.can_queue		= AHCI_MAX_CMDS - 1,			\
-	.sg_tablesize		= AHCI_MAX_SG,				\
-	.dma_boundary		= AHCI_DMA_BOUNDARY,			\
+	.sg_tablesize		= LIBATA_MAX_PRD,			\
+	.dma_boundary		= ATA_DMA_BOUNDARY			\
 	.shost_attrs		= ahci_shost_attrs,			\
 	.sdev_attrs		= ahci_sdev_attrs