Patchwork [Maverick] Stop ARM boards crashing when CUPS is loaded

login
register
mail settings
Submitter Lee Jones
Date July 16, 2010, 10:20 a.m.
Message ID <4C40327B.4040207@canonical.com>
Download mbox | patch
Permalink /patch/59090/
State Accepted
Delegated to: Leann Ogasawara
Headers show

Comments

Lee Jones - July 16, 2010, 10:20 a.m.
From b9462eba2e0d9ec687a8e6bf8046b24c1cecaf5f Mon Sep 17 00:00:00 2001
From: Lee Jones <lee.jones@canonical.com>
Date: Fri, 16 Jul 2010 09:37:31 +0100
Subject: [PATCH] UBUNTU: Stop ARM boards crashing when CUPS is loaded

BugLink: http://bugs.launchpad.net/bugs/601226

When CUPS loads, it tries to load several drivers it may need. When
one of these drivers, specifically parport_pc is loaded, it attempts
to write to address space normally reserved for ISA transactions.
On OMAP based systems, this causes a segmentation fault.

Signed-off-by: Lee Jones <lee.jones@canonical.com>
---
 drivers/parport/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Leann Ogasawara - July 16, 2010, 2:43 p.m.
Hi Lee,

I just want to clarify, did you want this applied to the Maverick
ti-omap4 branch or master or both?

Thanks,
Leann

On Fri, 2010-07-16 at 11:20 +0100, Lee Jones wrote:
> From b9462eba2e0d9ec687a8e6bf8046b24c1cecaf5f Mon Sep 17 00:00:00 2001
> From: Lee Jones <lee.jones@canonical.com>
> Date: Fri, 16 Jul 2010 09:37:31 +0100
> Subject: [PATCH] UBUNTU: Stop ARM boards crashing when CUPS is loaded
> 
> BugLink: http://bugs.launchpad.net/bugs/601226
> 
> When CUPS loads, it tries to load several drivers it may need. When
> one of these drivers, specifically parport_pc is loaded, it attempts
> to write to address space normally reserved for ISA transactions.
> On OMAP based systems, this causes a segmentation fault.
> 
> Signed-off-by: Lee Jones <lee.jones@canonical.com>
> ---
>  drivers/parport/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/parport/Kconfig b/drivers/parport/Kconfig
> index 855f389..9728c0b 100644
> --- a/drivers/parport/Kconfig
> +++ b/drivers/parport/Kconfig
> @@ -36,7 +36,7 @@ if PARPORT
>  config PARPORT_PC
>  	tristate "PC-style hardware"
>  	depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && \
> -		(!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN
> +		(!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN && !ARCH_OMAP
>  	---help---
>  	  You should say Y here if you have a PC-style parallel port. All
>  	  IBM PC compatible computers and some Alphas have PC-style
> -- 
> 1.7.0.4
>
Lee Jones - July 16, 2010, 2:52 p.m.
On 16/07/10 15:43, Leann Ogasawara wrote:
> Hi Lee,
> 
> I just want to clarify, did you want this applied to the Maverick
> ti-omap4 branch or master or both?

Both please Leann.

Kind regards,
Lee
Leann Ogasawara - July 17, 2010, 1:03 a.m.
Applied to Maverick linux master.  I'll let Tim apply this for the
ti-omap4 branch.

Thanks,
Leann

On Fri, 2010-07-16 at 11:20 +0100, Lee Jones wrote:
> From b9462eba2e0d9ec687a8e6bf8046b24c1cecaf5f Mon Sep 17 00:00:00 2001
> From: Lee Jones <lee.jones@canonical.com>
> Date: Fri, 16 Jul 2010 09:37:31 +0100
> Subject: [PATCH] UBUNTU: Stop ARM boards crashing when CUPS is loaded
> 
> BugLink: http://bugs.launchpad.net/bugs/601226
> 
> When CUPS loads, it tries to load several drivers it may need. When
> one of these drivers, specifically parport_pc is loaded, it attempts
> to write to address space normally reserved for ISA transactions.
> On OMAP based systems, this causes a segmentation fault.
> 
> Signed-off-by: Lee Jones <lee.jones@canonical.com>
> ---
>  drivers/parport/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/parport/Kconfig b/drivers/parport/Kconfig
> index 855f389..9728c0b 100644
> --- a/drivers/parport/Kconfig
> +++ b/drivers/parport/Kconfig
> @@ -36,7 +36,7 @@ if PARPORT
>  config PARPORT_PC
>  	tristate "PC-style hardware"
>  	depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && \
> -		(!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN
> +		(!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN && !ARCH_OMAP
>  	---help---
>  	  You should say Y here if you have a PC-style parallel port. All
>  	  IBM PC compatible computers and some Alphas have PC-style
> -- 
> 1.7.0.4
>
Tim Gardner - July 17, 2010, 3:45 p.m.
On 07/16/2010 04:52 PM, Lee Jones wrote:
> On 16/07/10 15:43, Leann Ogasawara wrote:
>> Hi Lee,
>>
>> I just want to clarify, did you want this applied to the Maverick
>> ti-omap4 branch or master or both?
>
> Both please Leann.
>
> Kind regards,
> Lee
>

applied to ti-omap4

Patch

diff --git a/drivers/parport/Kconfig b/drivers/parport/Kconfig
index 855f389..9728c0b 100644
--- a/drivers/parport/Kconfig
+++ b/drivers/parport/Kconfig
@@ -36,7 +36,7 @@  if PARPORT
 config PARPORT_PC
 	tristate "PC-style hardware"
 	depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && \
-		(!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN
+		(!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN && !ARCH_OMAP
 	---help---
 	  You should say Y here if you have a PC-style parallel port. All
 	  IBM PC compatible computers and some Alphas have PC-style