diff mbox

[1/2] char: PC rtc: replace blacklist with whitelist

Message ID 1456912137-1578635-1-git-send-email-arnd@arndb.de
State Superseded
Headers show

Commit Message

Arnd Bergmann March 2, 2016, 9:48 a.m. UTC
Every new architecture has to add itself to the growing list of those
that do not support the legacy PC RTC driver.

This replaces the long list of architectures that don't support it
with a shorter list of those that do.

The list is taken from those architectures that have a non-empty
asm/mc146818rtc.h header file and were not explicitly blacklisted.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/char/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Alexandre Belloni March 2, 2016, 10:03 a.m. UTC | #1
On 02/03/2016 at 10:48:50 +0100, Arnd Bergmann wrote :
> Every new architecture has to add itself to the growing list of those
> that do not support the legacy PC RTC driver.
> 
> This replaces the long list of architectures that don't support it
> with a shorter list of those that do.
> 
> The list is taken from those architectures that have a non-empty
> asm/mc146818rtc.h header file and were not explicitly blacklisted.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

> ---
>  drivers/char/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index a043107da2af..9716bc36495a 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -279,8 +279,7 @@ if RTC_LIB=n
>  
>  config RTC
>  	tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> -	depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
> -			&& !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN && !UML
> +	depends on ALPHA || M32R || M68K || MIPS || MN10300 || PPC || X86
>  	---help---
>  	  If you say Y here and create a character special file /dev/rtc with
>  	  major number 10 and minor number 135 using mknod ("man mknod"), you
> -- 
> 2.7.0
>
Geert Uytterhoeven March 2, 2016, 10:22 a.m. UTC | #2
On Wed, Mar 2, 2016 at 10:48 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> Every new architecture has to add itself to the growing list of those
> that do not support the legacy PC RTC driver.
>
> This replaces the long list of architectures that don't support it
> with a shorter list of those that do.
>
> The list is taken from those architectures that have a non-empty
> asm/mc146818rtc.h header file and were not explicitly blacklisted.

M68K was blacklisted...

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/char/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index a043107da2af..9716bc36495a 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -279,8 +279,7 @@ if RTC_LIB=n
>
>  config RTC
>         tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> -       depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
> -                       && !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN && !UML
> +       depends on ALPHA || M32R || M68K || MIPS || MN10300 || PPC || X86

... so please drop it here.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Alexandre Belloni April 10, 2016, 3:43 p.m. UTC | #3
Arnd,

On 02/03/2016 at 11:22:04 +0100, Geert Uytterhoeven wrote :
> On Wed, Mar 2, 2016 at 10:48 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > Every new architecture has to add itself to the growing list of those
> > that do not support the legacy PC RTC driver.
> >
> > This replaces the long list of architectures that don't support it
> > with a shorter list of those that do.
> >
> > The list is taken from those architectures that have a non-empty
> > asm/mc146818rtc.h header file and were not explicitly blacklisted.
> 
> M68K was blacklisted...
> 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  drivers/char/Kconfig | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> > index a043107da2af..9716bc36495a 100644
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig
> > @@ -279,8 +279,7 @@ if RTC_LIB=n
> >
> >  config RTC
> >         tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> > -       depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
> > -                       && !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN && !UML
> > +       depends on ALPHA || M32R || M68K || MIPS || MN10300 || PPC || X86
> 
> ... so please drop it here.
> 

Do you plan to resend that one?
Arnd Bergmann April 17, 2016, 4:16 p.m. UTC | #4
On Sunday 10 April 2016 17:43:52 Alexandre Belloni wrote:
> > >  config RTC
> > >         tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> > > -       depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
> > > -                       && !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN && !UML
> > > +       depends on ALPHA || M32R || M68K || MIPS || MN10300 || PPC || X86
> > 
> > ... so please drop it here.
> > 
> 
> Do you plan to resend that one?
> 

Yes, it's in my queue for resending, together with some other RTC patches.

	Arnd
diff mbox

Patch

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index a043107da2af..9716bc36495a 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -279,8 +279,7 @@  if RTC_LIB=n
 
 config RTC
 	tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
-	depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
-			&& !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN && !UML
+	depends on ALPHA || M32R || M68K || MIPS || MN10300 || PPC || X86
 	---help---
 	  If you say Y here and create a character special file /dev/rtc with
 	  major number 10 and minor number 135 using mknod ("man mknod"), you