diff mbox

Use special code for sigsetjmp only in cpu-exec.c

Message ID BLUPR0301MB20343A51B6AEAF14B5B4742D9EBB0@BLUPR0301MB2034.namprd03.prod.outlook.com
State New
Headers show

Commit Message

Andrew Baumann March 1, 2016, 5:46 p.m. UTC 
> From: Stefan Weil [mailto:sw@weilnetz.de]

> Sent: Tuesday, 1 March 2016 5:16 AM

> 

> Am 01.03.2016 um 13:22 schrieb Peter Maydell:

> > On 1 March 2016 at 11:54, Stefan Weil <sw@weilnetz.de> wrote:

> >> Am 01.03.2016 um 10:59 schrieb Peter Maydell:

> >>> I don't understand this patch. Why doesn't it work to have

> >>> sigsetjmp() be implemented the same way for every use that

> >>> QEMU makes of it?

> >> It does, as long as the "same way" is the correct one, namely

> >> the one without stack unwinding.

> >>

> >> The current code used to work, but re-arranged include files

> >> broke the working code somewhere in the past:

> >>

> >> include/sysemu/os-win32.h does the right thing at the

> >> wrong place. Its correct definition of sigsetjmp is overwritten by

> >> the definition from a Mingw-w64 system header file which

> >> triggers stack unwinding. Stack unwinding is fatal for

> >> QEMU's generated code.

> >>

> >> My patch makes sure that the critical code in cpu-exec.c

> >> gets the correct definition of sigsetjmp.

> > I think we should fix this by making sure that osdep.h

> > does the right thing -- ie that it gives us the correct

> > definition and prevents mingw's headers from overriding it

> > with the wrong thing (by ensuring that the offending system

> > header is included before we redefine things, or however

> > necessary). This is what osdep.h's purpose is -- to hide

> > annoying system-header workarounds and hacks rather than

> > putting them in the rest of QEMU code.

> >

> >> In addition, it removes code which might or might not

> >> change the default definition of sigsetjmp (depending

> >> on the order of include files). Now all other files beside

> >> cpu-exec.c will use the default behaviour with stack

> >> unwinding.

> > That seems wrong -- we should have the same behaviour for

> > sigsetjmp/siglongjmp everywhere we use it.

> >

> > thanks

> > -- PMM

> 

> Technically there is nothing wrong with using different behaviour

> for each setjmp or sigsetjmp.

> 

> The "best" solution would be to add any prologue / epilogue which

> is needed for stack unwinding to the generated code. Like that,

> no tricks with redefinitions of setjmp / sigsetjmp would be necessary.

> 

> As long as that solution is not available, I'd prefer the variant which

> is implemented by my patch and keep the workaround close to

> the single location where it is needed.

> 

> Your alternate solution would require

> inclusion of setjmp.h in include/sysemu/os-win32.h. Then every

> compilation for Windows would get that header file, resulting

> in a (small) overhead. In addition, there would be no stack

> unwinding for any setjmp/longjmp which is not the standard

> behaviour for Windows 64 bit (but which we had until it was

> broken). I simply don't know whether this has unwanted

> side effects (maybe for debugging or with crash dumps) -

> that's the reason why I'd minimize the non-standard behaviour.


FWIW, I don't see a big problem including setjmp.h from os-win32.h and then modifying the definition globally. The overhead you mention is just in compilation time, and it's pretty minor compared to all the other system header files already included. The lack of stack unwinding is also probably not an issue -- AFAIK nothing in qemu uses structured exception handling, and that is the only reason I'm aware of for needing to be able to unwind from a longjmp.

I have been getting along fine with the following local fix:


Cheers,
Andrew
diff mbox

Patch

--- a/include/sysemu/os-win32.h
+++ b/include/sysemu/os-win32.h
@@ -60,6 +60,7 @@ 
  * If this parameter is NULL, longjump does no stack unwinding.
  * That is what we need for QEMU. Passing the value of register rsp (default)
  * lets longjmp try a stack unwinding which will crash with generated code. */
+# include <setjmp.h>
 # undef setjmp
 # define setjmp(env) _setjmp(env, NULL)
 #endif