From patchwork Thu Jul 15 18:54:45 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 59031 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-px0-f184.google.com (mail-px0-f184.google.com [209.85.212.184]) by ozlabs.org (Postfix) with ESMTP id A6A43B6F1B for ; Fri, 16 Jul 2010 05:04:18 +1000 (EST) Received: by pxi12 with SMTP id 12sf706474pxi.11 for ; Thu, 15 Jul 2010 12:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :x-spam-status:x-spam-checker-version:x-mimedefang-filter :x-scanned-by:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe:content-type; bh=of0Xq9hBT+7mOhYRD2BZ0m24dXkf1UXpbh6lOEsNMnE=; b=DzcLXF2yd5aklt+SntF2JIRd4RvmoXcoo6B9wdsAk2/DndfMTg4Ybw7qYT+ktf6vkn XWKrgjhZLOlUUFomSy93xe/kzy9Pw+m5e8/6r5SfrXlZutm/w2D2Nr+zjXTJxP8bOfkP q8jCU4B6M1IESGAdZ/TFu9z0gWNXQ48WdqfNo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:date:from:to:cc:subject:message-id :in-reply-to:references:x-mailer:mime-version:x-spam-status :x-spam-checker-version:x-mimedefang-filter:x-scanned-by :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe:content-type; b=dbQaHu+/GaxSCk9OSNv9jucSppRzE2PqzwBhH67OwdWmXuEQqJp4yqCC/Ql3XsPQzf wzxeVAMIplf1F1sNHdiuOJ0tUdQCU9uAmdd/fGszvF3di3P8dqwUDSz8ZazfSV/UaqSn hIOklI8I0kCOXS/Z5nuG/WAvHKdRJE5BWLRHo= Received: by 10.142.149.8 with SMTP id w8mr1282360wfd.14.1279220656187; Thu, 15 Jul 2010 12:04:16 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.143.25.19 with SMTP id c19ls9521653wfj.3.p; Thu, 15 Jul 2010 12:04:15 -0700 (PDT) Received: by 10.142.232.13 with SMTP id e13mr4360977wfh.26.1279220654958; Thu, 15 Jul 2010 12:04:14 -0700 (PDT) Received: by 10.142.232.13 with SMTP id e13mr4360976wfh.26.1279220654893; Thu, 15 Jul 2010 12:04:14 -0700 (PDT) Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by gmr-mx.google.com with ESMTP id g1si1637638rva.7.2010.07.15.12.04.14; Thu, 15 Jul 2010 12:04:14 -0700 (PDT) Received-SPF: pass (google.com: domain of akpm@linux-foundation.org designates 140.211.169.13 as permitted sender) client-ip=140.211.169.13; Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id o6FJ0i8d003082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 15 Jul 2010 12:04:09 -0700 Received: from akpm.mtv.corp.google.com (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id o6FIsji0013128; Thu, 15 Jul 2010 11:54:45 -0700 Date: Thu, 15 Jul 2010 11:54:45 -0700 From: Andrew Morton To: Tiefei zang Cc: rtc-linux@googlegroups.com, Roy Zang , Wan ZongShun , Mingkai Hu , Gala Kumar-B11780 Subject: Re: [rtc-linux] Re: [PATCH v3] rtc: add support for DS3232 RTC Message-Id: <20100715115445.f7761071.akpm@linux-foundation.org> In-Reply-To: References: <1278924300-477-1-git-send-email-tie-fei.zang@freescale.com> <20100712163331.4435606e.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Spam-Status: No, hits=-3.495 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Original-Sender: akpm@linux-foundation.org X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of akpm@linux-foundation.org designates 140.211.169.13 as permitted sender) smtp.mail=akpm@linux-foundation.org Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , On Tue, 13 Jul 2010 10:07:53 +0800 Tiefei zang wrote: > > > > however the code _seems_ to be handling alarms and the Kconfig help > > says "If an interrupt is associated with the device, the alarm > > functionality is supported." so I'm all confused. __Perhaps you can send > > along the changelog text? > According to ZongShun's comment, I remove the alarm functions in the > code but forget to delete this help message. > Could you help to remove this line > "If an interrupt is associated with the device, the alarm > functionality is supported" in the help? I added this: From: Andrew Morton fix Kconfig help text Cc: Alessandro Zummo Cc: Jingchang Lu Cc: Kumar Gala Cc: Mingkai Hu Cc: Roy Zang Cc: Srikanth Srinivasan Cc: Wan ZongShun Signed-off-by: Andrew Morton --- drivers/rtc/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -puN drivers/rtc/Kconfig~rtc-add-support-for-ds3232-rtc-fix drivers/rtc/Kconfig --- a/drivers/rtc/Kconfig~rtc-add-support-for-ds3232-rtc-fix +++ a/drivers/rtc/Kconfig @@ -171,8 +171,7 @@ config RTC_DRV_DS3232 depends on RTC_CLASS && I2C help If you say yes here you get support for Dallas Semiconductor - DS3232 real-time clock chips. If an interrupt is associated - with the device, the alarm functionality is supported. + DS3232 real-time clock chips. This driver can also be built as a module. If so, the module will be called rtc-ds3232.