Message ID | 20100714162707.gz4dld54qowgos88-nzlynne@webmail.spamcop.net |
---|---|
State | New |
Headers | show |
Joern Rennecke <amylaar@spamcop.net> writes: >> Your change for PR testsuite/42843 introduced a regression from 4.5. > > Indeed. The previous code used @CC@, which is directly substituted by > autoconf, whereas my patch used $(COMPILER), which is based on $(CC) and > $(CXX), which, albeit set to @CC@ / @CXX@ in the Makefile, are overridden > by the toplevel make. > > The attached patch restores the status quo ante of PLUGINCC / PLUGINCFLAGS > settings when not using --enable-build-with-cxx, while using > @CXX@ / @CXXFLAGS@ when --enable-build-with-cxx is in use. > > Bootstrapped & regession tested with and without --enable-build-with-cxx > in revision 162120 on i5585-pc-linux-gnu. > > The results with and without this patch are identical on my system, > except that I can observe in the generated site.exp that the previous > stage gcc is used instead of the system gcc / g++; > in comment #18 on PR42843, Jack Howarth confirmed that this patch > fixes the compiler selection issue that he sees on his system. > > What this patch does not address is the failure of several tests to include > "diagnostic.h", which should probably done in a separate patch. Unfortunately, this patch has remained unreviewed for 6 weeks. Given that it fixes a regression from 4.5 by (apart from also dealing with --enable-build-with-cxx) reverting an earlier patch of yours, I'd suggest to install it as obvious. Thanks. Rainer
On Thu, Aug 26, 2010 at 17:17, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote: > Unfortunately, this patch has remained unreviewed for 6 weeks. Given > that it fixes a regression from 4.5 by (apart from also dealing with > --enable-build-with-cxx) reverting an earlier patch of yours, I'd > suggest to install it as obvious. Reverts do not need explicit maintainer approval indeed. Paolo
Paolo Bonzini <bonzini@gnu.org> writes: > On Thu, Aug 26, 2010 at 17:17, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote: >> Unfortunately, this patch has remained unreviewed for 6 weeks. Given >> that it fixes a regression from 4.5 by (apart from also dealing with >> --enable-build-with-cxx) reverting an earlier patch of yours, I'd >> suggest to install it as obvious. > > Reverts do not need explicit maintainer approval indeed. Given all this and the fact that the patch still hasn't been committed, I've done that now. Rainer
Index: gcc/Makefile.in =================================================================== --- gcc/Makefile.in (revision 162120) +++ gcc/Makefile.in (working copy) @@ -330,11 +330,14 @@ enable_lto = @enable_lto@ LTO_BINARY_READER = @LTO_BINARY_READER@ LTO_USE_LIBELF = @LTO_USE_LIBELF@ -# Compiler needed for plugin support -PLUGINCC = $(COMPILER) - -# Flags needed for plugin support -PLUGINCFLAGS = $(COMPILER_FLAGS) +# Compiler and flags needed for plugin support +ifneq ($(ENABLE_BUILD_WITH_CXX),yes) +PLUGINCC = @CC@ +PLUGINCFLAGS = @CFLAGS@ +else +PLUGINCC = @CXX@ +PLUGINCFLAGS = @CXXFLAGS@ +endif # Libs and linker options needed for plugin support PLUGINLIBS = @pluginlibs@