Patchwork Remove incorrect pci_mem_base setting in bonito northbridge

login
register
mail settings
Submitter chen huacai
Date July 14, 2010, 11:51 a.m.
Message ID <1279108309-28213-1-git-send-email-zltjiangshi@gmail.com>
Download mbox | patch
Permalink /patch/58881/
State New
Headers show

Comments

chen huacai - July 14, 2010, 11:51 a.m.
This mistake makes PCI devices can't work correctly.

Signed-off-by: Huacai Chen <zltjiangshi@gmail.com>
---
 hw/bonito.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Aurelien Jarno - July 14, 2010, 12:42 p.m.
On Wed, Jul 14, 2010 at 07:51:49PM +0800, Huacai Chen wrote:
> This mistake makes PCI devices can't work correctly.
> 
> Signed-off-by: Huacai Chen <zltjiangshi@gmail.com>
> ---
>  hw/bonito.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

Thanks, applied.

> diff --git a/hw/bonito.c b/hw/bonito.c
> index 8b81032..dcf0311 100644
> --- a/hw/bonito.c
> +++ b/hw/bonito.c
> @@ -775,7 +775,6 @@ PCIBus *bonito_init(qemu_irq *pic)
>                           pci_bonito_map_irq, pic, 0x28, 32);
>      pcihost->bus = b;
>      qdev_init_nofail(dev);
> -    pci_bus_set_mem_base(pcihost->bus, 0x10000000);
>  
>      d = pci_create_simple(b, PCI_DEVFN(0, 0), "Bonito");
>      s = DO_UPCAST(PCIBonitoState, dev, d);
> -- 
> 1.7.0.4
> 
> 
>

Patch

diff --git a/hw/bonito.c b/hw/bonito.c
index 8b81032..dcf0311 100644
--- a/hw/bonito.c
+++ b/hw/bonito.c
@@ -775,7 +775,6 @@  PCIBus *bonito_init(qemu_irq *pic)
                          pci_bonito_map_irq, pic, 0x28, 32);
     pcihost->bus = b;
     qdev_init_nofail(dev);
-    pci_bus_set_mem_base(pcihost->bus, 0x10000000);
 
     d = pci_create_simple(b, PCI_DEVFN(0, 0), "Bonito");
     s = DO_UPCAST(PCIBonitoState, dev, d);