Message ID | 1456459256-32643-9-git-send-email-sjg@chromium.org |
---|---|
State | Accepted |
Commit | 1872c67359ca7940e7442384288279811a9019b2 |
Delegated to: | Tom Rini |
Headers | show |
On Thu, Feb 25, 2016 at 09:00:55PM -0700, Simon Glass wrote: > These files do not need to be compiled when CONFIG_CMDLINE is disabled. > Update the Makefile to reflect this. > > Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Tom Rini <trini@konsulko.com> ... but did you buildman the world here? iirc, we have some cases that fake running a command to make something important happen here.
Hi Tom, On 26 February 2016 at 10:17, Tom Rini <trini@konsulko.com> wrote: > On Thu, Feb 25, 2016 at 09:00:55PM -0700, Simon Glass wrote: > >> These files do not need to be compiled when CONFIG_CMDLINE is disabled. >> Update the Makefile to reflect this. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> > > Reviewed-by: Tom Rini <trini@konsulko.com> > > ... but did you buildman the world here? iirc, we have some cases that > fake running a command to make something important happen here. Not on this commit, but for the series. I will though. It is definitely possible that enabling the option will create build errors. For one, you need a board_run_command() function to be present. I've tested it for sandbox and am actually thinking of adding a sandbox board without commands. Regards, Simon
diff --git a/common/Makefile b/common/Makefile index 117178a..b15113c 100644 --- a/common/Makefile +++ b/common/Makefile @@ -148,10 +148,10 @@ endif endif # We always have this since drivers/ddr/fs/interactive.c needs it -obj-y += cli_simple.o +obj-$(CONFIG_CMDLINE) += cli_simple.o obj-y += cli.o -obj-y += cli_readline.o +obj-$(CONFIG_CMDLINE) += cli_readline.o obj-y += command.o obj-y += s_record.o obj-y += xyzModem.o
These files do not need to be compiled when CONFIG_CMDLINE is disabled. Update the Makefile to reflect this. Signed-off-by: Simon Glass <sjg@chromium.org> --- common/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)