| Message ID | 1456334871-30397-1-git-send-email-fbarrat@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, 2016-02-24 at 18:27 +0100, Frederic Barrat wrote: > The PSL timebase synchronization is seemingly failing for > configuration not including VIRT_CPU_ACCOUNTING_NATIVE. The driver > shows the following trace in dmesg: > PSL: Timebase sync: giving up! > > The PSL timebase register is actually syncing correctly, but the cxl > driver is not detecting it. Fix is to use the proper timebase-to-time > conversion. > > Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com> Looks good! Acked-by: Michael Neuling <mikey@neuling.org> > Cc: <stable@vger.kernel.org> # 4.3+ > --- > drivers/misc/cxl/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c > index 4c1903f..0c6c17a1 100644 > --- a/drivers/misc/cxl/pci.c > +++ b/drivers/misc/cxl/pci.c > @@ -415,7 +415,7 @@ static int cxl_setup_psl_timebase(struct cxl > *adapter, struct pci_dev *dev) > delta = mftb() - psl_tb; > if (delta < 0) > delta = -delta; > - } while (cputime_to_usecs(delta) > 16); > + } while (tb_to_ns(delta) > 16000); > > return 0; > }
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
On 25/02/16 04:27, Frederic Barrat wrote: > The PSL timebase synchronization is seemingly failing for > configuration not including VIRT_CPU_ACCOUNTING_NATIVE. The driver > shows the following trace in dmesg: > PSL: Timebase sync: giving up! > > The PSL timebase register is actually syncing correctly, but the cxl > driver is not detecting it. Fix is to use the proper timebase-to-time > conversion. > > Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com> > Cc: <stable@vger.kernel.org> # 4.3+ Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Frederic Barrat <fbarrat@linux.vnet.ibm.com> writes: > The PSL timebase synchronization is seemingly failing for > configuration not including VIRT_CPU_ACCOUNTING_NATIVE. The driver > shows the following trace in dmesg: > PSL: Timebase sync: giving up! > > The PSL timebase register is actually syncing correctly, but the cxl > driver is not detecting it. Fix is to use the proper timebase-to-time > conversion. > > Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com> > Cc: <stable@vger.kernel.org> # 4.3+ Reviewed-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
On Wed, 2016-24-02 at 17:27:51 UTC, Frederic Barrat wrote: > The PSL timebase synchronization is seemingly failing for > configuration not including VIRT_CPU_ACCOUNTING_NATIVE. The driver > shows the following trace in dmesg: > PSL: Timebase sync: giving up! > > The PSL timebase register is actually syncing correctly, but the cxl > driver is not detecting it. Fix is to use the proper timebase-to-time > conversion. > > Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com> > Cc: <stable@vger.kernel.org> # 4.3+ > Acked-by: Michael Neuling <mikey@neuling.org> > Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com> > Acked-by: Ian Munsie <imunsie@au1.ibm.com> > Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > Reviewed-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com> Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/923adb1646d5ba739d2a1e63ee cheers
diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c index 4c1903f..0c6c17a1 100644 --- a/drivers/misc/cxl/pci.c +++ b/drivers/misc/cxl/pci.c @@ -415,7 +415,7 @@ static int cxl_setup_psl_timebase(struct cxl *adapter, struct pci_dev *dev) delta = mftb() - psl_tb; if (delta < 0) delta = -delta; - } while (cputime_to_usecs(delta) > 16); + } while (tb_to_ns(delta) > 16000); return 0; }
The PSL timebase synchronization is seemingly failing for configuration not including VIRT_CPU_ACCOUNTING_NATIVE. The driver shows the following trace in dmesg: PSL: Timebase sync: giving up! The PSL timebase register is actually syncing correctly, but the cxl driver is not detecting it. Fix is to use the proper timebase-to-time conversion. Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com> Cc: <stable@vger.kernel.org> # 4.3+ --- drivers/misc/cxl/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)