Message ID | 1456303822-2638-1-git-send-email-clsee@altera.com |
---|---|
State | Deferred |
Delegated to: | Marek Vasut |
Headers | show |
On 02/24/2016 09:50 AM, Chin Liang See wrote: > Enabling the support of storing U-Boot environment > within serial NOR flash. By default, its still > store into SDMMC > > Signed-off-by: Chin Liang See <clsee@altera.com> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > Cc: Dinh Nguyen <dinh.linux@gmail.com> > Cc: Pavel Machek <pavel@denx.de> > Cc: Marek Vasut <marex@denx.de> > Cc: Stefan Roese <sr@denx.de> I am fine with the patch, but why did I receive it thrice ? ;-) > --- > include/configs/socfpga_common.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h > index a09e906..c1eef54 100644 > --- a/include/configs/socfpga_common.h > +++ b/include/configs/socfpga_common.h > @@ -291,6 +291,12 @@ unsigned int cm_get_qspi_controller_clk_hz(void); > #define CONFIG_ENV_OFFSET 512 /* just after the MBR */ > #endif > > +/* Environment for QSPI boot */ > +#if defined(CONFIG_ENV_IS_IN_SPI_FLASH) && !defined(CONFIG_ENV_OFFSET) > +#define CONFIG_ENV_OFFSET 0x00100000 > +#define CONFIG_ENV_SECT_SIZE (64 * 1024) > +#endif > + > /* > * mtd partitioning for serial NOR flash > * >
On Wed, 2016-02-24 at 18:44 +0100, Marek Vasut wrote: > On 02/24/2016 09:50 AM, Chin Liang See wrote: > > Enabling the support of storing U-Boot environment > > within serial NOR flash. By default, its still > > store into SDMMC > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > Cc: Pavel Machek <pavel@denx.de> > > Cc: Marek Vasut <marex@denx.de> > > Cc: Stefan Roese <sr@denx.de> > > I am fine with the patch, but why did I receive it thrice ? ;-) > Sorry about this as I thought IT blocked the email sending. I noticed the U-Boot mailing didn't show the patch after 10 mins. I was surprised to see 3 and guess it took longer time to go through IT servers screening :) Thanks Chin Liang > > --- > > include/configs/socfpga_common.h | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/include/configs/socfpga_common.h > > b/include/configs/socfpga_common.h > > index a09e906..c1eef54 100644 > > --- a/include/configs/socfpga_common.h > > +++ b/include/configs/socfpga_common.h > > @@ -291,6 +291,12 @@ unsigned int > > cm_get_qspi_controller_clk_hz(void); > > #define CONFIG_ENV_OFFSET 512 /* just after > > the MBR */ > > #endif > > > > +/* Environment for QSPI boot */ > > +#if defined(CONFIG_ENV_IS_IN_SPI_FLASH) && > > !defined(CONFIG_ENV_OFFSET) > > +#define CONFIG_ENV_OFFSET 0x00100000 > > +#define CONFIG_ENV_SECT_SIZE (64 * 1024) > > +#endif > > + > > /* > > * mtd partitioning for serial NOR flash > > * > > >
On 02/26/2016 02:06 PM, Chin Liang See wrote: > On Wed, 2016-02-24 at 18:44 +0100, Marek Vasut wrote: >> On 02/24/2016 09:50 AM, Chin Liang See wrote: >>> Enabling the support of storing U-Boot environment >>> within serial NOR flash. By default, its still >>> store into SDMMC >>> >>> Signed-off-by: Chin Liang See <clsee@altera.com> >>> Cc: Dinh Nguyen <dinguyen@opensource.altera.com> >>> Cc: Dinh Nguyen <dinh.linux@gmail.com> >>> Cc: Pavel Machek <pavel@denx.de> >>> Cc: Marek Vasut <marex@denx.de> >>> Cc: Stefan Roese <sr@denx.de> >> >> I am fine with the patch, but why did I receive it thrice ? ;-) >> > > Sorry about this as I thought IT blocked the email sending. I noticed > the U-Boot mailing didn't show the patch after 10 mins. I was surprised > to see 3 and guess it took longer time to go through IT servers > screening :) Gotcha! btw I started screening the patches a bit more. socfpga_sr1500 produces a warning with this patch. Please use buildman to build your patches, something like: ./tools/buildman/buildman -b u-boot/master..HEAD -defsS "socfpga" will do the trick.
On Fri, 2016-02-26 at 19:08 +0100, Marek Vasut wrote: > On 02/26/2016 02:06 PM, Chin Liang See wrote: > > On Wed, 2016-02-24 at 18:44 +0100, Marek Vasut wrote: > > > On 02/24/2016 09:50 AM, Chin Liang See wrote: > > > > Enabling the support of storing U-Boot environment > > > > within serial NOR flash. By default, its still > > > > store into SDMMC > > > > > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > > > Cc: Pavel Machek <pavel@denx.de> > > > > Cc: Marek Vasut <marex@denx.de> > > > > Cc: Stefan Roese <sr@denx.de> > > > > > > I am fine with the patch, but why did I receive it thrice ? ;-) > > > > > > > Sorry about this as I thought IT blocked the email sending. I > > noticed > > the U-Boot mailing didn't show the patch after 10 mins. I was > > surprised > > to see 3 and guess it took longer time to go through IT servers > > screening :) > > Gotcha! > > btw I started screening the patches a bit more. socfpga_sr1500 > produces > a warning with this patch. > > Please use buildman to build your patches, something like: > > ./tools/buildman/buildman -b u-boot/master..HEAD -defsS "socfpga" > > will do the trick. Oops, thanks for reminding this as we talked about this prior my long holiday. I managed to get the buildman works but seems need 2 steps. The first step is without the -defsS and without the "" too. Thanks Chin Liang >
On 03/01/2016 07:38 AM, Chin Liang See wrote: > On Fri, 2016-02-26 at 19:08 +0100, Marek Vasut wrote: >> On 02/26/2016 02:06 PM, Chin Liang See wrote: >>> On Wed, 2016-02-24 at 18:44 +0100, Marek Vasut wrote: >>>> On 02/24/2016 09:50 AM, Chin Liang See wrote: >>>>> Enabling the support of storing U-Boot environment >>>>> within serial NOR flash. By default, its still >>>>> store into SDMMC >>>>> >>>>> Signed-off-by: Chin Liang See <clsee@altera.com> >>>>> Cc: Dinh Nguyen <dinguyen@opensource.altera.com> >>>>> Cc: Dinh Nguyen <dinh.linux@gmail.com> >>>>> Cc: Pavel Machek <pavel@denx.de> >>>>> Cc: Marek Vasut <marex@denx.de> >>>>> Cc: Stefan Roese <sr@denx.de> >>>> >>>> I am fine with the patch, but why did I receive it thrice ? ;-) >>>> >>> >>> Sorry about this as I thought IT blocked the email sending. I >>> noticed >>> the U-Boot mailing didn't show the patch after 10 mins. I was >>> surprised >>> to see 3 and guess it took longer time to go through IT servers >>> screening :) >> >> Gotcha! >> >> btw I started screening the patches a bit more. socfpga_sr1500 >> produces >> a warning with this patch. >> >> Please use buildman to build your patches, something like: >> >> ./tools/buildman/buildman -b u-boot/master..HEAD -defsS "socfpga" >> >> will do the trick. > > Oops, thanks for reminding this as we talked about this prior my long > holiday. I managed to get the buildman works but seems need 2 steps. > The first step is without the -defsS and without the "" too. Ah, right. It's really convenient tool, right ? ;-)
On Tue, 2016-03-01 at 14:51 +0100, Marek Vasut wrote: > On 03/01/2016 07:38 AM, Chin Liang See wrote: > > On Fri, 2016-02-26 at 19:08 +0100, Marek Vasut wrote: > > > On 02/26/2016 02:06 PM, Chin Liang See wrote: > > > > On Wed, 2016-02-24 at 18:44 +0100, Marek Vasut wrote: > > > > > On 02/24/2016 09:50 AM, Chin Liang See wrote: > > > > > > Enabling the support of storing U-Boot environment > > > > > > within serial NOR flash. By default, its still > > > > > > store into SDMMC > > > > > > > > > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > > > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > > > > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > > > > > Cc: Pavel Machek <pavel@denx.de> > > > > > > Cc: Marek Vasut <marex@denx.de> > > > > > > Cc: Stefan Roese <sr@denx.de> > > > > > > > > > > I am fine with the patch, but why did I receive it thrice ? ; > > > > > -) > > > > > > > > > > > > > Sorry about this as I thought IT blocked the email sending. I > > > > noticed > > > > the U-Boot mailing didn't show the patch after 10 mins. I was > > > > surprised > > > > to see 3 and guess it took longer time to go through IT servers > > > > screening :) > > > > > > Gotcha! > > > > > > btw I started screening the patches a bit more. socfpga_sr1500 > > > produces > > > a warning with this patch. > > > > > > Please use buildman to build your patches, something like: > > > > > > ./tools/buildman/buildman -b u-boot/master..HEAD -defsS "socfpga" > > > > > > will do the trick. > > > > Oops, thanks for reminding this as we talked about this prior my > > long > > holiday. I managed to get the buildman works but seems need 2 > > steps. > > The first step is without the -defsS and without the "" too. > > Ah, right. It's really convenient tool, right ? ;-) > Yup, I fully agree :) The same command can be used even we added new boards or socfpga devices. Thanks Chin Liang
diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h index a09e906..c1eef54 100644 --- a/include/configs/socfpga_common.h +++ b/include/configs/socfpga_common.h @@ -291,6 +291,12 @@ unsigned int cm_get_qspi_controller_clk_hz(void); #define CONFIG_ENV_OFFSET 512 /* just after the MBR */ #endif +/* Environment for QSPI boot */ +#if defined(CONFIG_ENV_IS_IN_SPI_FLASH) && !defined(CONFIG_ENV_OFFSET) +#define CONFIG_ENV_OFFSET 0x00100000 +#define CONFIG_ENV_SECT_SIZE (64 * 1024) +#endif + /* * mtd partitioning for serial NOR flash *
Enabling the support of storing U-Boot environment within serial NOR flash. By default, its still store into SDMMC Signed-off-by: Chin Liang See <clsee@altera.com> Cc: Dinh Nguyen <dinguyen@opensource.altera.com> Cc: Dinh Nguyen <dinh.linux@gmail.com> Cc: Pavel Machek <pavel@denx.de> Cc: Marek Vasut <marex@denx.de> Cc: Stefan Roese <sr@denx.de> --- include/configs/socfpga_common.h | 6 ++++++ 1 file changed, 6 insertions(+)