diff mbox

[U-Boot] colibri-vf: Disable pull-up configuration in GPIO pin mux

Message ID 1456302804-3059-1-git-send-email-bhuvanchandra.dv@toradex.com
State Accepted
Commit fc9e8f2817d8024f2c1e0e13c80111a9fa4bbce9
Delegated to: Stefano Babic
Headers show

Commit Message

Bhuvanchandra DV Feb. 24, 2016, 8:33 a.m. UTC
During very early boot-ROM execution the pinmux
configuration isi in Hi-Z state. If pull-up is enabled
on GPIO pad's there will be a short period of toggle
from high to low on the IO when GPIO is set low during
boot. To avoid this glitch, disable pull-up configuration
in GPIO pinmux.

Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
---
 arch/arm/include/asm/arch-vf610/iomux-vf610.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefano Babic March 2, 2016, 1:48 p.m. UTC | #1
On 24/02/2016 09:33, Bhuvanchandra DV wrote:
> During very early boot-ROM execution the pinmux
> configuration isi in Hi-Z state. If pull-up is enabled
> on GPIO pad's there will be a short period of toggle
> from high to low on the IO when GPIO is set low during
> boot. To avoid this glitch, disable pull-up configuration
> in GPIO pinmux.
> 
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> ---
>  arch/arm/include/asm/arch-vf610/iomux-vf610.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/arch-vf610/iomux-vf610.h b/arch/arm/include/asm/arch-vf610/iomux-vf610.h
> index 0e2bd53..a140be0 100644
> --- a/arch/arm/include/asm/arch-vf610/iomux-vf610.h
> +++ b/arch/arm/include/asm/arch-vf610/iomux-vf610.h
> @@ -34,7 +34,7 @@
>  				PAD_CTL_PUS_22K_UP | PAD_CTL_OBE_IBE_ENABLE)
>  
>  #define VF610_GPIO_PAD_CTRL	(PAD_CTL_SPEED_MED | PAD_CTL_DSE_50ohm | \
> -				PAD_CTL_PUS_47K_UP | PAD_CTL_IBE_ENABLE)
> +				PAD_CTL_IBE_ENABLE)
>  
>  #define VF610_DSPI_PAD_CTRL	(PAD_CTL_OBE_ENABLE | PAD_CTL_DSE_20ohm | \
>  				PAD_CTL_PUS_100K_UP | PAD_CTL_SPEED_HIGH)
> 

As fix, applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/arch/arm/include/asm/arch-vf610/iomux-vf610.h b/arch/arm/include/asm/arch-vf610/iomux-vf610.h
index 0e2bd53..a140be0 100644
--- a/arch/arm/include/asm/arch-vf610/iomux-vf610.h
+++ b/arch/arm/include/asm/arch-vf610/iomux-vf610.h
@@ -34,7 +34,7 @@ 
 				PAD_CTL_PUS_22K_UP | PAD_CTL_OBE_IBE_ENABLE)
 
 #define VF610_GPIO_PAD_CTRL	(PAD_CTL_SPEED_MED | PAD_CTL_DSE_50ohm | \
-				PAD_CTL_PUS_47K_UP | PAD_CTL_IBE_ENABLE)
+				PAD_CTL_IBE_ENABLE)
 
 #define VF610_DSPI_PAD_CTRL	(PAD_CTL_OBE_ENABLE | PAD_CTL_DSE_20ohm | \
 				PAD_CTL_PUS_100K_UP | PAD_CTL_SPEED_HIGH)