From patchwork Tue Jul 13 08:54:19 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 58719 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bilbo.ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id D1747100A31 for ; Tue, 13 Jul 2010 19:24:47 +1000 (EST) Received: by ozlabs.org (Postfix) id 37358B6F11; Tue, 13 Jul 2010 19:24:41 +1000 (EST) Delivered-To: linuxppc-dev@ozlabs.org X-Greylist: delayed 1812 seconds by postgrey-1.32 at bilbo; Tue, 13 Jul 2010 19:24:40 EST Received: from pqueueb.post.tele.dk (pqueueb.post.tele.dk [193.162.153.10]) by ozlabs.org (Postfix) with ESMTP id 812ECB6F0E for ; Tue, 13 Jul 2010 19:24:40 +1000 (EST) Received: from pfepb.post.tele.dk (pfepb.post.tele.dk [195.41.46.236]) by pqueueb.post.tele.dk (Postfix) with ESMTP id 93EEB814D for ; Tue, 13 Jul 2010 10:54:25 +0200 (CEST) Received: from merkur.ravnborg.org (x1-6-00-1e-2a-84-ae-3e.k225.webspeed.dk [80.163.61.94]) by pfepb.post.tele.dk (Postfix) with ESMTP id 8F1B2F84023; Tue, 13 Jul 2010 10:54:19 +0200 (CEST) Date: Tue, 13 Jul 2010 10:54:19 +0200 From: Sam Ravnborg To: Sean MacLennan Subject: Re: section .data..init_task Message-ID: <20100713085419.GA5826@merkur.ravnborg.org> References: <20100628005900.28d4a8e0@lappy.seanm.ca> <20100712203435.08a3e90f@lappy.seanm.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100712203435.08a3e90f@lappy.seanm.ca> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: Denys Vlasenko , linuxppc-dev , Tim Abbott X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org On Mon, Jul 12, 2010 at 08:34:35PM -0400, Sean MacLennan wrote: > On Mon, 28 Jun 2010 00:59:00 -0400 > Sean MacLennan wrote: > > > Anybody else seeing these messages? > > > > ppc_4xxFP-ld: .tmp_vmlinux1: section .data..init_task lma 0xc0374000 > > overlaps previous sections ppc_4xxFP-ld: .tmp_vmlinux2: > > section .data..init_task lma 0xc03a2000 overlaps previous sections > > ppc_4xxFP-ld: vmlinux: section .data..init_task lma 0xc03a2000 > > overlaps previous sections > > > > Or does anybody know what they mean? They started showing up in > > 2.6.35. > > > > Very easy to reproduce, so don't hesitate to ask for more info. > > I had a bit of time, so I tracked this down. This patch seems to be > the culprit: http://lkml.org/lkml/2010/2/19/366 > > Specifically, this code: > > /* The initial task and kernel stack */ > - .data.init_task : AT(ADDR(.data.init_task) - LOAD_OFFSET) { > - INIT_TASK_DATA(THREAD_SIZE) > - } > + INIT_TASK_DATA_SECTION(THREAD_SIZE) > > If I change it back to: > > /* The initial task and kernel stack */ > .data..init_task : AT(ADDR(.data..init_task) - LOAD_OFFSET) { > INIT_TASK_DATA(THREAD_SIZE) > } > > not only do the warnings go away, but the kernel now boots again! It looks like a missing AT() in the output section. The following patch should also fix it. Please test and let us know. Thanks, Sam diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index 48c5299..3c4bf03 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -435,7 +435,7 @@ */ #define INIT_TASK_DATA_SECTION(align) \ . = ALIGN(align); \ - .data..init_task : { \ + .data..init_task : AT(ADDR(.data..init_task) - LOAD_OFFSET) { \ INIT_TASK_DATA(align) \ }