From patchwork Tue Jul 13 09:21:40 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: UBIFS memleak ?
From: Matthieu CASTET <matthieu.castet@parrot.com>
X-Patchwork-Id: 58718
Message-Id: <4C3C3024.8050104@parrot.com>
To: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Date: Tue, 13 Jul 2010 11:21:40 +0200

Hi,

in mount_ubifs shouldn't we do something like that in case of 
ubifs_leb_unmap error ?


Matthieu

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 4d2f215..9362f16 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -1318,7 +1318,7 @@ static int mount_ubifs(struct ubifs_info *c)
 			 */
 			err = ubifs_leb_unmap(c, c->gc_lnum);
 			if (err)
-				return err;
+				goto out_orphans;
 		}
 
 		err = dbg_check_lprops(c);