Patchwork UBIFS memleak ?

login
register
mail settings
Submitter Matthieu CASTET
Date July 13, 2010, 9:21 a.m.
Message ID <4C3C3024.8050104@parrot.com>
Download mbox | patch
Permalink /patch/58718/
State Accepted
Commit c18de72fb3c72fdc5ca883910761af3f14d90d76
Headers show

Comments

Matthieu CASTET - July 13, 2010, 9:21 a.m.
Hi,

in mount_ubifs shouldn't we do something like that in case of 
ubifs_leb_unmap error ?


Matthieu
Artem Bityutskiy - July 18, 2010, 8:53 a.m.
On Tue, 2010-07-13 at 11:21 +0200, Matthieu CASTET wrote:
> Hi,
> 
> in mount_ubifs shouldn't we do something like that in case of 
> ubifs_leb_unmap error ?

Yes, are you going to send a proper patch with signed-off-by?

Patch

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 4d2f215..9362f16 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -1318,7 +1318,7 @@  static int mount_ubifs(struct ubifs_info *c)
 			 */
 			err = ubifs_leb_unmap(c, c->gc_lnum);
 			if (err)
-				return err;
+				goto out_orphans;
 		}
 
 		err = dbg_check_lprops(c);