Patchwork [testsuite] Require C99 runtime, visibility support in some testcases

login
register
mail settings
Submitter Rainer Orth
Date July 12, 2010, 12:04 p.m.
Message ID <yddbpacucrs.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Download mbox | patch
Permalink /patch/58598/
State New
Headers show

Comments

Rainer Orth - July 12, 2010, 12:04 p.m.
A couple of testcases are failing on Solaris 8 and 9/x86 because they
fail to declare their requirements:

* gcc.dg/pr42427.c failed:

FAIL: gcc.dg/pr42427.c (test for excess errors)
Excess errors:
/vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.dg/pr42427.c:5:21: fatal error: complex.h: No such file or directory
compilation terminated.

  This test obviously needs a C99 runtime.

* gcc.target/i386/pr37275.c fails:

FAIL: gcc.target/i386/pr37275.c -Wl,-M,/vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.target/i386/clearcap.map (test for excess errors)
Excess errors:
/vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.target/i386/pr37275.c:137:1: warning: visibility attribute not supported in this configuration; ignored [-Wattributes]

  The test needs to declare its visibility requirement.

* gcc.target/i386/sse-cmpss-1.c fails:

FAIL: gcc.target/i386/sse-cmpss-1.c -Wl,-M,/vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.target/i386/clearcap.map (test for excess errors)
Excess errors:
/vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.target/i386/sse-cmpss-1.c:46:5: warning: implicit declaration of function 'isunordered' [-Wimplicit-function-declaration]
Undefined			first referenced
 symbol  			    in file
isunordered                         /var/tmp//ccZN1GQg.o
ld: fatal: Symbol referencing errors. No output written to ./sse-cmpss-1.exe

  Again, a test with undeclared need for a C99 runtime.  The same
  problem exists in several AVX testcases.

Bootstrapped on Solaris 8 to 11 without regressions, ok for mainline
(and 4.4, 4.5 branches after testing completes)?  This is probably close
to obvious, though.

Thanks.
	Rainer


2010-06-19  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* gcc.dg/pr42427.c: Require c99_runtime.
	* gcc.target/i386/avx-cmpsd-1.c: Use dg-require-effective-target
	c99_runtime.
	* gcc.target/i386/avx-cmpss-1.c: Likewise.
	* gcc.target/i386/avx-vcmppd-1.c: Likewise.
	* gcc.target/i386/avx-vcmppd-256-1.c: Likewise.
	* gcc.target/i386/avx-vcmpps-1.c: Likewise.
	* gcc.target/i386/avx-vcmpps-256-1.c: Likewise.
	* gcc.target/i386/avx-vcmpsd-1.c: Likewise.
	* gcc.target/i386/avx-vcmpss-1.c: Likewise.
	* gcc.target/i386/sse-cmpss-1.c: Likewise.
	* gcc.target/i386/sse2-cmpsd-1.c: Likewise
	* gcc.target/i386/pr37275.c: Require visibility support.
Uros Bizjak - July 12, 2010, 12:11 p.m.
On Mon, Jul 12, 2010 at 2:04 PM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:

> 2010-06-19  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>        * gcc.dg/pr42427.c: Require c99_runtime.
>        * gcc.target/i386/avx-cmpsd-1.c: Use dg-require-effective-target
>        c99_runtime.
>        * gcc.target/i386/avx-cmpss-1.c: Likewise.
>        * gcc.target/i386/avx-vcmppd-1.c: Likewise.
>        * gcc.target/i386/avx-vcmppd-256-1.c: Likewise.
>        * gcc.target/i386/avx-vcmpps-1.c: Likewise.
>        * gcc.target/i386/avx-vcmpps-256-1.c: Likewise.
>        * gcc.target/i386/avx-vcmpsd-1.c: Likewise.
>        * gcc.target/i386/avx-vcmpss-1.c: Likewise.
>        * gcc.target/i386/sse-cmpss-1.c: Likewise.
>        * gcc.target/i386/sse2-cmpsd-1.c: Likewise
>        * gcc.target/i386/pr37275.c: Require visibility support.

OK everywhere.

Thanks,
Uros.

Patch

diff -r a7ad92cd9b59 gcc/testsuite/gcc.dg/pr42427.c
--- a/gcc/testsuite/gcc.dg/pr42427.c	Fri Jul 09 12:54:43 2010 +0200
+++ b/gcc/testsuite/gcc.dg/pr42427.c	Fri Jul 09 12:58:18 2010 +0200
@@ -1,5 +1,6 @@ 
-/* { dg-do assemble } */
+/* { dg-do assemble { target c99_runtime } } */
 /* { dg-options "-O2 -fexceptions -fnon-call-exceptions -fpeel-loops" } */
+/* { dg-add-options c99_runtime } */
 /* { dg-require-effective-target ilp32 } */
 
 #include <complex.h>
diff -r a7ad92cd9b59 gcc/testsuite/gcc.target/i386/avx-cmpsd-1.c
--- a/gcc/testsuite/gcc.target/i386/avx-cmpsd-1.c	Fri Jul 09 12:54:43 2010 +0200
+++ b/gcc/testsuite/gcc.target/i386/avx-cmpsd-1.c	Fri Jul 09 12:58:18 2010 +0200
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
+/* { dg-require-effective-target c99_runtime } */
 /* { dg-options "-O2 -mavx -std=c99" } */
 
 #define CHECK_H "avx-check.h"
diff -r a7ad92cd9b59 gcc/testsuite/gcc.target/i386/avx-cmpss-1.c
--- a/gcc/testsuite/gcc.target/i386/avx-cmpss-1.c	Fri Jul 09 12:54:43 2010 +0200
+++ b/gcc/testsuite/gcc.target/i386/avx-cmpss-1.c	Fri Jul 09 12:58:18 2010 +0200
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
+/* { dg-require-effective-target c99_runtime } */
 /* { dg-options "-O2 -mavx -std=c99" } */
 
 #define CHECK_H "avx-check.h"
diff -r a7ad92cd9b59 gcc/testsuite/gcc.target/i386/avx-vcmppd-1.c
--- a/gcc/testsuite/gcc.target/i386/avx-vcmppd-1.c	Fri Jul 09 12:54:43 2010 +0200
+++ b/gcc/testsuite/gcc.target/i386/avx-vcmppd-1.c	Fri Jul 09 12:58:18 2010 +0200
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
+/* { dg-require-effective-target c99_runtime } */
 /* { dg-options "-O2 -mavx -std=c99" } */
 
 #include "avx-check.h"
diff -r a7ad92cd9b59 gcc/testsuite/gcc.target/i386/avx-vcmppd-256-1.c
--- a/gcc/testsuite/gcc.target/i386/avx-vcmppd-256-1.c	Fri Jul 09 12:54:43 2010 +0200
+++ b/gcc/testsuite/gcc.target/i386/avx-vcmppd-256-1.c	Fri Jul 09 12:58:18 2010 +0200
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
+/* { dg-require-effective-target c99_runtime } */
 /* { dg-options "-O2 -mavx -std=c99" } */
 
 #include "avx-check.h"
diff -r a7ad92cd9b59 gcc/testsuite/gcc.target/i386/avx-vcmpps-1.c
--- a/gcc/testsuite/gcc.target/i386/avx-vcmpps-1.c	Fri Jul 09 12:54:43 2010 +0200
+++ b/gcc/testsuite/gcc.target/i386/avx-vcmpps-1.c	Fri Jul 09 12:58:18 2010 +0200
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
+/* { dg-require-effective-target c99_runtime } */
 /* { dg-options "-O2 -mavx -std=c99" } */
 
 #include "avx-check.h"
diff -r a7ad92cd9b59 gcc/testsuite/gcc.target/i386/avx-vcmpps-256-1.c
--- a/gcc/testsuite/gcc.target/i386/avx-vcmpps-256-1.c	Fri Jul 09 12:54:43 2010 +0200
+++ b/gcc/testsuite/gcc.target/i386/avx-vcmpps-256-1.c	Fri Jul 09 12:58:18 2010 +0200
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
+/* { dg-require-effective-target c99_runtime } */
 /* { dg-options "-O2 -mavx -std=c99" } */
 
 #include "avx-check.h"
diff -r a7ad92cd9b59 gcc/testsuite/gcc.target/i386/avx-vcmpsd-1.c
--- a/gcc/testsuite/gcc.target/i386/avx-vcmpsd-1.c	Fri Jul 09 12:54:43 2010 +0200
+++ b/gcc/testsuite/gcc.target/i386/avx-vcmpsd-1.c	Fri Jul 09 12:58:18 2010 +0200
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
+/* { dg-require-effective-target c99_runtime } */
 /* { dg-options "-O2 -mavx -std=c99" } */
 
 #include "avx-check.h"
diff -r a7ad92cd9b59 gcc/testsuite/gcc.target/i386/avx-vcmpss-1.c
--- a/gcc/testsuite/gcc.target/i386/avx-vcmpss-1.c	Fri Jul 09 12:54:43 2010 +0200
+++ b/gcc/testsuite/gcc.target/i386/avx-vcmpss-1.c	Fri Jul 09 12:58:18 2010 +0200
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target avx } */
+/* { dg-require-effective-target c99_runtime } */
 /* { dg-options "-O2 -mavx -std=c99" } */
 
 #include "avx-check.h"
diff -r a7ad92cd9b59 gcc/testsuite/gcc.target/i386/pr37275.c
--- a/gcc/testsuite/gcc.target/i386/pr37275.c	Fri Jul 09 12:54:43 2010 +0200
+++ b/gcc/testsuite/gcc.target/i386/pr37275.c	Fri Jul 09 12:58:18 2010 +0200
@@ -1,6 +1,7 @@ 
 /* PR middle-end/37275 */
 /* { dg-do compile { target ilp32 } } */
 /* { dg-options "-g -dA -O2 -march=i686 -fstack-protector" } */
+/* { dg-require-visibility "" } */
 
 typedef __SIZE_TYPE__ size_t;
 extern void *memcpy (void *, const void *, size_t);
diff -r a7ad92cd9b59 gcc/testsuite/gcc.target/i386/sse-cmpss-1.c
--- a/gcc/testsuite/gcc.target/i386/sse-cmpss-1.c	Fri Jul 09 12:54:43 2010 +0200
+++ b/gcc/testsuite/gcc.target/i386/sse-cmpss-1.c	Fri Jul 09 12:58:18 2010 +0200
@@ -1,6 +1,7 @@ 
 /* { dg-do run } */
 /* { dg-options "-O2 -msse -std=c99" } */
 /* { dg-require-effective-target sse } */
+/* { dg-require-effective-target c99_runtime } */
 
 #ifndef CHECK_H
 #define CHECK_H "sse-check.h"
diff -r a7ad92cd9b59 gcc/testsuite/gcc.target/i386/sse2-cmpsd-1.c
--- a/gcc/testsuite/gcc.target/i386/sse2-cmpsd-1.c	Fri Jul 09 12:54:43 2010 +0200
+++ b/gcc/testsuite/gcc.target/i386/sse2-cmpsd-1.c	Fri Jul 09 12:58:18 2010 +0200
@@ -1,6 +1,7 @@ 
 /* { dg-do run } */
 /* { dg-options "-O2 -msse2 -std=c99" } */
 /* { dg-require-effective-target sse2 } */
+/* { dg-require-effective-target c99_runtime } */
 
 #ifndef CHECK_H
 #define CHECK_H "sse2-check.h"