diff mbox

[01/10] package/gnuradio: add optional support for orc

Message ID 1456076099-19607-1-git-send-email-bernd.kuhls@t-online.de
State Accepted
Headers show

Commit Message

Bernd Kuhls Feb. 21, 2016, 5:34 p.m. UTC
When orc was compiled before, gnuradio will use it as optional
dependency:

$ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/bin/gnuradio-config-info | grep NEEDED
[...]
 0x0000000000000001 (NEEDED)             Shared library: [liborc-0.4.so.0]
[...]

Apparently there is no option provided by the build system to
en-/disable support for orc:
https://github.com/gnuradio/volk/blob/41b4df055b2c8d4f2c23ad2bdc60c0b47b4f0dd8/lib/CMakeLists.txt#L449

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/gnuradio/gnuradio.mk | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Petazzoni Feb. 21, 2016, 8:18 p.m. UTC | #1
Dear Bernd Kuhls,

On Sun, 21 Feb 2016 18:34:50 +0100, Bernd Kuhls wrote:
> When orc was compiled before, gnuradio will use it as optional
> dependency:
> 
> $ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/bin/gnuradio-config-info | grep NEEDED
> [...]
>  0x0000000000000001 (NEEDED)             Shared library: [liborc-0.4.so.0]
> [...]
> 
> Apparently there is no option provided by the build system to
> en-/disable support for orc:
> https://github.com/gnuradio/volk/blob/41b4df055b2c8d4f2c23ad2bdc60c0b47b4f0dd8/lib/CMakeLists.txt#L449
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Can you check it properly finds the orcc compiler in
$(HOST_DIR)/usr/bin ? I believe this might need some more tweaks than
just depending on orc.

I'm Cc'ing Gwenhael, who is the main contributor to the GNURadio
package. Gwenhael, can you have a look at Bernd's patch to enable ORC
as an optional dependency of GNURadio ?

Thanks!

Thomas
Gwenhael Goavec-Merou Feb. 22, 2016, 2:23 p.m. UTC | #2
Hi Bernd,

Reviewed-by: "Gwenhael Goavec-Merou" <gwenhael.goavec-merou@trabucayre.com>
Tested-by: "Gwenhael Goavec-Merou" <gwenhael.goavec-merou@trabucayre.com>

Best regards,

Gwenhael

On Sun, 21 Feb 2016 18:34:50 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> When orc was compiled before, gnuradio will use it as optional
> dependency:
> 
> $ output/host/usr/bin/x86_64-linux-readelf -a
> output/target/usr/bin/gnuradio-config-info | grep NEEDED [...]
>  0x0000000000000001 (NEEDED)             Shared library:
> [liborc-0.4.so.0] [...]
> 
> Apparently there is no option provided by the build system to
> en-/disable support for orc:
> https://github.com/gnuradio/volk/blob/41b4df055b2c8d4f2c23ad2bdc60c0b47b4f0dd8/lib/CMakeLists.txt#L449
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/gnuradio/gnuradio.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/gnuradio/gnuradio.mk
> b/package/gnuradio/gnuradio.mk index fc5cd1f..b7dbcb9 100644
> --- a/package/gnuradio/gnuradio.mk
> +++ b/package/gnuradio/gnuradio.mk
> @@ -17,6 +17,10 @@ GNURADIO_DEPENDENCIES = \
>  	host-swig \
>  	boost
>  
> +ifeq ($(BR2_PACKAGE_ORC),y)
> +GNURADIO_DEPENDENCIES += orc
> +endif
> +
>  GNURADIO_CONF_OPTS = \
>  	-DENABLE_DEFAULT=OFF \
>  	-DENABLE_VOLK=ON \
> -- 
> 2.7.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni Feb. 23, 2016, 9:21 p.m. UTC | #3
Dear Bernd Kuhls,

On Sun, 21 Feb 2016 18:34:50 +0100, Bernd Kuhls wrote:
> When orc was compiled before, gnuradio will use it as optional
> dependency:
> 
> $ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/bin/gnuradio-config-info | grep NEEDED
> [...]
>  0x0000000000000001 (NEEDED)             Shared library: [liborc-0.4.so.0]
> [...]
> 
> Apparently there is no option provided by the build system to
> en-/disable support for orc:
> https://github.com/gnuradio/volk/blob/41b4df055b2c8d4f2c23ad2bdc60c0b47b4f0dd8/lib/CMakeLists.txt#L449
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/gnuradio/gnuradio.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master, thanks!

Thanks to Gwenhael for testing!

Thomas
diff mbox

Patch

diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
index fc5cd1f..b7dbcb9 100644
--- a/package/gnuradio/gnuradio.mk
+++ b/package/gnuradio/gnuradio.mk
@@ -17,6 +17,10 @@  GNURADIO_DEPENDENCIES = \
 	host-swig \
 	boost
 
+ifeq ($(BR2_PACKAGE_ORC),y)
+GNURADIO_DEPENDENCIES += orc
+endif
+
 GNURADIO_CONF_OPTS = \
 	-DENABLE_DEFAULT=OFF \
 	-DENABLE_VOLK=ON \