diff mbox

[3/8] package/links: add --with/--without-ssl

Message ID 1455986411-14273-4-git-send-email-bernd.kuhls@t-online.de
State Superseded
Headers show

Commit Message

Bernd Kuhls Feb. 20, 2016, 4:40 p.m. UTC 
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/links/links.mk | 3 +++
 1 file changed, 3 insertions(+)

Comments

Yann E. MORIN Feb. 20, 2016, 5:43 p.m. UTC | #1 
Bernd, All,

On 2016-02-20 17:40 +0100, Bernd Kuhls spake thusly:
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/links/links.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/links/links.mk b/package/links/links.mk
> index 3515e5f..3a4519f 100644
> --- a/package/links/links.mk
> +++ b/package/links/links.mk
> @@ -44,7 +44,10 @@ LINKS_DEPENDENCIES += libevent
>  endif
>  
>  ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +LINKS_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr --enable-ssl-pkgconfig

So, even when using pkg-config, we still need to tell it where OpenSSL
is located?

Regards,
Yann E. MORIN.

>  LINKS_DEPENDENCIES += openssl
> +else
> +LINKS_CONF_OPTS += --without-ssl
>  endif
>  
>  ifeq ($(BR2_PACKAGE_XZ),y)
> -- 
> 2.7.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Bernd Kuhls Feb. 20, 2016, 5:47 p.m. UTC | #2 
Am Sat, 20 Feb 2016 18:43:48 +0100 schrieb Yann E. MORIN:

>>  ifeq ($(BR2_PACKAGE_OPENSSL),y)
>> +LINKS_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr
>> --enable-ssl-pkgconfig
> 
> So, even when using pkg-config, we still need to tell it where OpenSSL
> is located?

Hi,

no, it works without the path to $STAGING_DIR, I just wanted to make 
sure ;)

Regards, Bernd
Yann E. MORIN Feb. 20, 2016, 5:50 p.m. UTC | #3 
Bernd, All,

On 2016-02-20 18:47 +0100, Bernd Kuhls spake thusly:
> Am Sat, 20 Feb 2016 18:43:48 +0100 schrieb Yann E. MORIN:
> 
> >>  ifeq ($(BR2_PACKAGE_OPENSSL),y)
> >> +LINKS_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr
> >> --enable-ssl-pkgconfig
> > 
> > So, even when using pkg-config, we still need to tell it where OpenSSL
> > is located?
> 
> no, it works without the path to $STAGING_DIR, I just wanted to make 
> sure ;)

Then do not provide it, please.

Thanks!

Regards,
Yann E. MORIN.
Bernd Kuhls Feb. 20, 2016, 7:50 p.m. UTC | #4 
Am Sat, 20 Feb 2016 18:50:42 +0100 schrieb Yann E. MORIN:

> Then do not provide it, please.

Hi Yann,

done: http://patchwork.ozlabs.org/patch/585662/

Regards, Bernd
diff mbox

Patch

diff --git a/package/links/links.mk b/package/links/links.mk
index 3515e5f..3a4519f 100644
--- a/package/links/links.mk
+++ b/package/links/links.mk
@@ -44,7 +44,10 @@  LINKS_DEPENDENCIES += libevent
 endif
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LINKS_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr --enable-ssl-pkgconfig
 LINKS_DEPENDENCIES += openssl
+else
+LINKS_CONF_OPTS += --without-ssl
 endif
 
 ifeq ($(BR2_PACKAGE_XZ),y)