diff mbox

[1/6] Mtd: fixed coding style indent errors

Message ID 4C3A8220.6040707@gmail.com
State New, archived
Headers show

Commit Message

Neal Buckendahl July 12, 2010, 2:46 a.m. UTC 
From f4301b9c13f65d173d67759d53acaf3e8d2331c6 Mon Sep 17 00:00:00 2001
From: Neal Buckendahl <nealb001@gmail.com>
Date: Sun, 11 Jul 2010 16:58:24 -0500
Subject: [PATCH 1/6] Mtd: fixed coding style indent errors found by the 
checkpatch.pl tool
  Signed-off-by: Neal Buckendahl <nealb001@gmail.com>

---
  drivers/mtd/afs.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

  	u_int mask, off, idx, sz;

Comments

Artem Bityutskiy July 18, 2010, 7:27 a.m. UTC | #1 
On Sun, 2010-07-11 at 21:46 -0500, Neal B wrote:
> From f4301b9c13f65d173d67759d53acaf3e8d2331c6 Mon Sep 17 00:00:00 2001
> From: Neal Buckendahl <nealb001@gmail.com>
> Date: Sun, 11 Jul 2010 16:58:24 -0500
> Subject: [PATCH 1/6] Mtd: fixed coding style indent errors found by the 
> checkpatch.pl tool
>   Signed-off-by: Neal Buckendahl <nealb001@gmail.com>

Unfortunately, your patches are line-wrapped. You should send
non-wrapped patches. Use git send-email - it can do the trick (use
--dry-run first, check everything is fine, then send).

Also, int the commit message, it is a bit better to specify which
exactly warning it fixes.
diff mbox

Patch

diff --git a/drivers/mtd/afs.c b/drivers/mtd/afs.c
index cec7ab9..2bea681 100644
--- a/drivers/mtd/afs.c
+++ b/drivers/mtd/afs.c
@@ -162,8 +162,8 @@  afs_read_iis(struct mtd_info *mtd, struct 
image_info_struct *iis, u_int ptr)
  }

  static int parse_afs_partitions(struct mtd_info *mtd,
-                         struct mtd_partition **pparts,
-                         unsigned long origin)
+			struct mtd_partition **pparts,
+			unsigned long origin)
  {
  	struct mtd_partition *parts;